Bug 237827
| Summary: | Wrong init script | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Michal Marciniszyn <mmarcini> | ||||
| Component: | cachefilesd | Assignee: | David Howells <dhowells> | ||||
| Status: | CLOSED ERRATA | QA Contact: | |||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 5.0 | CC: | ohudlick, tvujec | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | RHEL5.1NAK | ||||||
| Fixed In Version: | RHBA-2008-0412 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-05-21 16:54:46 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 237789, 237828, 237829 | ||||||
| Attachments: |
|
||||||
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Changing status to ASSIGNED Iniscripts are still broken: condrestart only stop the service Some fixing in specfile is also recommended. More info in errata. The condrestart problem is due to a bug in /etc/init.d/functions (bug 440658). This can be worked around by making condrestart invoke stop and start directly rather than by invoking restart and letting that then invoke stop and start. The problem is that the status() function uses pidof, with exclusions for itself and its parent process, but doesn't give exclusions for its grandparent, great-grandparent, etc., but the cachefilesd recurses more then once. This means there are several scripts all called 'cachefilesd' in addition to the actual caching daemon all running at the same time. There's also a problem whereby the stop function does not wait for the cachefilesd daemon to complete (which might take some time). This can be fixed by putting in a short wait. Created attachment 300431 [details]
Further initscript fixes (work around status() and wait for stop completion)
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2008-0412.html |
Description of problem: Following code if [ ! -f /etc/sysconfig/network ]; then exit 0 fi . /etc/sysconfig/network # Check that networking is up. [ "${NETWORKING}" = "no" ] && exit 0 returns exit code 0 even if the service is not runnung. There are several other constructions in the script and incorrect return codes. Version-Release number of selected component (if applicable): all How reproducible: always Steps to Reproduce: 1. service network stop 2. service chachefilesd start/status 3. echo $? Actual results: 0 Expected results: non-zero exit code/status of the service Additional info: When fixing this bug, please obbey our init script guidelines and be sure that status command is run correctly. Our guidelines are on following two pages: http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html For an example of the script that returns the error codes correctly and always runs status see: http://devserv.devel.redhat.com/~mmarcini/amd This bug is tracked by 237789.