Bug 2378885
| Summary: | python-rasterio fails to build with click 8.2.1 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Charalampos Stratakis <cstratak> |
| Component: | python-click | Assignee: | Charalampos Stratakis <cstratak> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | cstratak, epel-packagers-sig, igor.raits, infra-sig, jonathan, loganjerry, mhroncok, python-packagers-sig, quantum.analyst |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | python-click-8.1.7-10.fc43 | Doc Type: | --- |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-09-18 00:16:48 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2339432, 2373702, 2384424, 2365473, 2385986 | ||
|
Description
Charalampos Stratakis
2025-07-08 21:12:44 UTC
There are several failures like:
______________________ test_delete_nodata_exclusive_opts _______________________
data = local('/tmp/pytest-of-mockbuild/pytest-0/test_delete_nodata_exclusive_o0')
runner = <click.testing.CliRunner object at 0x7f836fdd3c40>
def test_delete_nodata_exclusive_opts(data, runner):
"""--unset-nodata and --nodata can't be used together"""
inputfile = str(data.join('RGB.byte.tif'))
result = runner.invoke(
main_group, ['edit-info', inputfile, '--unset-nodata', '--nodata', '0'])
> assert result.exit_code == 2
E assert 1 == 2
E + where 1 = <Result TypeError("string indices must be integers, not 'str'")>.exit_code
tests/test_rio_edit_info.py:49: AssertionError
In this case, the option `allmd` is the string 'False' instead of the default boolean False. This seems like it might be one of the regressions aimed to be fixed by https://src.fedoraproject.org/rpms/python-click/pull-request/27
OK, pulling the build from that PR actually introduces new issues because the sentinel value is now passed to the callbacks, but even after fixing that, the original issue remains. I do not know if that is a bug in click or something intentional. Hello. This is a bulk comment. This package still needs to be rebuilt and/or shipped with Python 3.14.0rc2+ bytecode in Fedora 43. The Beta Freeze of Fedora 43 is scheduled to start today. Please prioritize this bugzilla accordingly. Thanks. Even with the backport of https://github.com/pallets/click/pull/3030, there remains an upstream issue in click: https://github.com/pallets/click/issues/3054 Also another regression in 8.2.1: https://github.com/pallets/click/issues/2939 Re-assigning to click as these are all regressions outside of rasterio. (In reply to Elliott Sales de Andrade from comment #4) > Even with the backport of https://github.com/pallets/click/pull/3030, there > remains an upstream issue in click: > https://github.com/pallets/click/issues/3054 OK, click upstream has told me that this is a bug in rasterio, so I will fix that there. The other issue is still in click. Revert to 8.1.7 in https://src.fedoraproject.org/rpms/python-click/pull-request/29 FEDORA-2025-f34d0f958e (python-click-8.1.7-10.fc44, python-pyinfra-3.4.1-3.fc44, and 2 more) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-f34d0f958e FEDORA-2025-f34d0f958e (python-click-8.1.7-10.fc44, python-pyinfra-3.4.1-3.fc44, and 2 more) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-2a54399b96 (python-click-8.1.7-10.fc43, python-click-repl-0.2.0-16.fc43, and 4 more) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-2a54399b96 FEDORA-2025-2a54399b96 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-2a54399b96` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-2a54399b96 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. For full rasterio support, I've opened https://src.fedoraproject.org/rpms/python-rasterio/pull-request/8 but it can wait until click 8.3 happens or a new rasterio release obsoletes it. FEDORA-2025-2a54399b96 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-2a54399b96` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-2a54399b96 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-2a54399b96 (python-click-8.1.7-10.fc43, python-click-repl-0.2.0-16.fc43, and 8 more) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. |