Bug 2378885 - python-rasterio fails to build with click 8.2.1
Summary: python-rasterio fails to build with click 8.2.1
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-click
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Charalampos Stratakis
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F43FTBFS PYC3.14rc3 F44FTBFS, RAWHIDEFTBFS 2365473 2385986
TreeView+ depends on / blocked
 
Reported: 2025-07-08 21:12 UTC by Charalampos Stratakis
Modified: 2025-09-18 00:16 UTC (History)
9 users (show)

Fixed In Version: python-click-8.1.7-10.fc43
Clone Of:
Environment:
Last Closed: 2025-09-18 00:16:48 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github pallets click issues 2939 0 None open Click 8.2.1 CliRunner raises SystemExit(1) when using click.File's stdin support 2025-09-02 04:10:05 UTC
Github pallets click issues 3054 0 None open flag_value:str and default=False produces str value 2025-09-02 00:38:39 UTC
Github pallets click pull 3030 0 None Merged Differentiate absence of value and value of absence for `default` and `flag_value` arguments 2025-09-02 00:38:39 UTC

Description Charalampos Stratakis 2025-07-08 21:12:44 UTC
Hello,

We are planning to update click from 8.1.7 to 8.2.1 in Rawhide.

However python-rasterio fails to build with the latest click version.

You can inspect the build failures at https://copr.fedorainfracloud.org/coprs/cstratak/click-8.2.1/package/python-rasterio/

Let us know here if you have any questions.

We'd appreciate help from the people who know this package best, but if you don't want
to work on this now, let us know so we can try to work around it on our side.

Comment 1 Elliott Sales de Andrade 2025-08-19 01:09:13 UTC
There are several failures like:

______________________ test_delete_nodata_exclusive_opts _______________________

data = local('/tmp/pytest-of-mockbuild/pytest-0/test_delete_nodata_exclusive_o0')
runner = <click.testing.CliRunner object at 0x7f836fdd3c40>

    def test_delete_nodata_exclusive_opts(data, runner):
        """--unset-nodata and --nodata can't be used together"""
        inputfile = str(data.join('RGB.byte.tif'))
        result = runner.invoke(
            main_group, ['edit-info', inputfile, '--unset-nodata', '--nodata', '0'])
>       assert result.exit_code == 2
E       assert 1 == 2
E        +  where 1 = <Result TypeError("string indices must be integers, not 'str'")>.exit_code

tests/test_rio_edit_info.py:49: AssertionError

In this case, the option `allmd` is the string 'False' instead of the default boolean False. This seems like it might be one of the regressions aimed to be fixed by https://src.fedoraproject.org/rpms/python-click/pull-request/27

Comment 2 Elliott Sales de Andrade 2025-08-19 01:24:45 UTC
OK, pulling the build from that PR actually introduces new issues because the sentinel value is now passed to the callbacks, but even after fixing that, the original issue remains. I do not know if that is a bug in click or something intentional.

Comment 3 Miro Hrončok 2025-08-26 11:08:43 UTC
Hello. This is a bulk comment.

This package still needs to be rebuilt and/or shipped with Python 3.14.0rc2+ bytecode in Fedora 43.

The Beta Freeze of Fedora 43 is scheduled to start today. Please prioritize this bugzilla accordingly.

Thanks.

Comment 4 Elliott Sales de Andrade 2025-09-02 00:38:39 UTC
Even with the backport of https://github.com/pallets/click/pull/3030, there remains an upstream issue in click: https://github.com/pallets/click/issues/3054

Comment 5 Elliott Sales de Andrade 2025-09-02 04:10:06 UTC
Also another regression in 8.2.1: https://github.com/pallets/click/issues/2939

Comment 6 Elliott Sales de Andrade 2025-09-02 04:30:14 UTC
Re-assigning to click as these are all regressions outside of rasterio.

Comment 7 Elliott Sales de Andrade 2025-09-02 07:47:00 UTC
(In reply to Elliott Sales de Andrade from comment #4)
> Even with the backport of https://github.com/pallets/click/pull/3030, there
> remains an upstream issue in click:
> https://github.com/pallets/click/issues/3054

OK, click upstream has told me that this is a bug in rasterio, so I will fix that there. The other issue is still in click.

Comment 8 Miro Hrončok 2025-09-02 07:51:09 UTC
Revert to 8.1.7 in https://src.fedoraproject.org/rpms/python-click/pull-request/29

Comment 9 Fedora Update System 2025-09-04 10:49:39 UTC
FEDORA-2025-f34d0f958e (python-click-8.1.7-10.fc44, python-pyinfra-3.4.1-3.fc44, and 2 more) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-f34d0f958e

Comment 10 Fedora Update System 2025-09-04 11:41:04 UTC
FEDORA-2025-f34d0f958e (python-click-8.1.7-10.fc44, python-pyinfra-3.4.1-3.fc44, and 2 more) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2025-09-04 12:39:24 UTC
FEDORA-2025-2a54399b96 (python-click-8.1.7-10.fc43, python-click-repl-0.2.0-16.fc43, and 4 more) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-2a54399b96

Comment 12 Fedora Update System 2025-09-05 01:29:25 UTC
FEDORA-2025-2a54399b96 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-2a54399b96`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-2a54399b96

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Elliott Sales de Andrade 2025-09-07 22:55:23 UTC
For full rasterio support, I've opened https://src.fedoraproject.org/rpms/python-rasterio/pull-request/8 but it can wait until click 8.3 happens or a new rasterio release obsoletes it.

Comment 14 Fedora Update System 2025-09-08 01:56:43 UTC
FEDORA-2025-2a54399b96 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-2a54399b96`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-2a54399b96

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2025-09-18 00:16:48 UTC
FEDORA-2025-2a54399b96 (python-click-8.1.7-10.fc43, python-click-repl-0.2.0-16.fc43, and 8 more) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.