Bug 2379489
| Summary: | Review Request: kopia - cross-platform backup tool | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nianqing Yao <imbearchild> | ||||||
| Component: | Package Review | Assignee: | U2FsdGVkX1 | ||||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | package-review, U2FsdGVkX1 | ||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||
| Target Release: | --- | Flags: | U2FsdGVkX1:
fedora-review?
|
||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | --- | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | --- | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Nianqing Yao
2025-07-11 04:47:48 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9369227 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2379489-kopia/fedora-rawhide-x86_64/09369227-kopia/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Update to 0.21.1 Spec URL: https://raw.githubusercontent.com/ImBearChild/copr-home/refs/heads/main/kopia/kopia.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/imbearchild/home/fedora-rawhide-x86_64/09639275-kopia/kopia-0.21.1-1.fc44.src.rpm Copr Build: https://copr.fedorainfracloud.org/coprs/imbearchild/home/build/9639275 Created attachment 2108344 [details]
The .spec file difference from Copr build 9369227 to 9642261
Copr build: https://copr.fedorainfracloud.org/coprs/build/9642261 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2379489-kopia/fedora-rawhide-x86_64/09642261-kopia/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Issues found during the review:
1. File listed twice /usr/share/licenses/kopia
2. Unescaped macros in comments Please escape these by using # %%gobuild instead
kopia.spec:59: W: macro-in-comment %gobuild
kopia.spec:59: W: macro-in-comment %{gobuilddir}
kopia.spec:59: W: macro-in-comment %{goipath}
I apologize for my delayed response.
I encountered some issues with Copr. The build environment for source RPMs uses Fedora 42, but the upstream project, Kopia, has updated its required Go version to 1.25, which exceeds the stock Go version provided by Fedora 42. Additionally, I've experienced some peculiar behavior with the dnf copr command: while it successfully adds repository files, it doesn't utilize them, and they do not appear in the dnf repolist. As a result, I had to employ a workaround to build the source RPM successfully.
Regarding the issues you pointed out:
1. The problem seems to stem from %{go_vendor_license_filelist}, which I cannot rectify within the spec file.
2. I have removed the unnecessary comment lines.
I have updated the spec file and initiated a new Copr build for your review.
-----
Spec URL: https://raw.githubusercontent.com/ImBearChild/copr-home/refs/heads/main/kopia/kopia.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/imbearchild/home/fedora-rawhide-x86_64/09911073-kopia/kopia-0.22.3-1.fc44.src.rpm
Copr Build: https://copr.fedorainfracloud.org/coprs/imbearchild/home/build/9911073/
Created attachment 2118913 [details]
The .spec file difference from Copr build 9642261 to 9914366
Copr build: https://copr.fedorainfracloud.org/coprs/build/9914366 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2379489-kopia/fedora-rawhide-x86_64/09914366-kopia/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. |