Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://raw.githubusercontent.com/ImBearChild/copr-home/refs/heads/main/kopia/kopia.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/imbearchild/home/fedora-rawhide-x86_64/09264683-kopia/kopia-0.20.1-1.fc43.src.rpm Description: Cross-platform backup tool for Windows, macOS & Linux with fast, incremental backups, client-side end-to-end encryption, compression and data deduplication. Fedora Account System Username: imbearchild Upstream: https://github.com/kopia/kopia Kopia is a fast and secure open-source backup/restore tool that allows you to create encrypted snapshots of your data and save the snapshots to remote or cloud storage of your choice, to network-attached storage or server, or locally on your machine.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9369227 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2379489-kopia/fedora-rawhide-x86_64/09369227-kopia/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Update to 0.21.1 Spec URL: https://raw.githubusercontent.com/ImBearChild/copr-home/refs/heads/main/kopia/kopia.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/imbearchild/home/fedora-rawhide-x86_64/09639275-kopia/kopia-0.21.1-1.fc44.src.rpm Copr Build: https://copr.fedorainfracloud.org/coprs/imbearchild/home/build/9639275
Created attachment 2108344 [details] The .spec file difference from Copr build 9369227 to 9642261
Copr build: https://copr.fedorainfracloud.org/coprs/build/9642261 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2379489-kopia/fedora-rawhide-x86_64/09642261-kopia/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Issues found during the review: 1. File listed twice /usr/share/licenses/kopia 2. Unescaped macros in comments Please escape these by using # %%gobuild instead kopia.spec:59: W: macro-in-comment %gobuild kopia.spec:59: W: macro-in-comment %{gobuilddir} kopia.spec:59: W: macro-in-comment %{goipath}
I apologize for my delayed response. I encountered some issues with Copr. The build environment for source RPMs uses Fedora 42, but the upstream project, Kopia, has updated its required Go version to 1.25, which exceeds the stock Go version provided by Fedora 42. Additionally, I've experienced some peculiar behavior with the dnf copr command: while it successfully adds repository files, it doesn't utilize them, and they do not appear in the dnf repolist. As a result, I had to employ a workaround to build the source RPM successfully. Regarding the issues you pointed out: 1. The problem seems to stem from %{go_vendor_license_filelist}, which I cannot rectify within the spec file. 2. I have removed the unnecessary comment lines. I have updated the spec file and initiated a new Copr build for your review. ----- Spec URL: https://raw.githubusercontent.com/ImBearChild/copr-home/refs/heads/main/kopia/kopia.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/imbearchild/home/fedora-rawhide-x86_64/09911073-kopia/kopia-0.22.3-1.fc44.src.rpm Copr Build: https://copr.fedorainfracloud.org/coprs/imbearchild/home/build/9911073/
Created attachment 2118913 [details] The .spec file difference from Copr build 9642261 to 9914366
Copr build: https://copr.fedorainfracloud.org/coprs/build/9914366 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2379489-kopia/fedora-rawhide-x86_64/09914366-kopia/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to the latest upstream release (kopia 0.23.1). With the current Fedora, the previous workaround for building the source RPM is no longer needed. The two points from the previous review were already addressed in my reply in comment 6 (the lines with unescaped macros were removed; the duplicate entry under /usr/share/licenses/kopia comes from %{go_vendor_license_filelist} and cannot be changed in the spec). A note on %check: a few upstream tests with hard-coded values break on Fedora 45 / Rawhide because Go 1.27 changed the stdlib compress/flate encoder output and the encoding/json (v2) error text; the runtime format is unaffected. I added a spec-level workaround that skips only those brittle tests (%gotestflags -skip ...), plus one test that is flaky due to an upstream goroutine data race. Upstream has already fixed the Go 1.27 issues in commit 56ff291 (kopia#5681), so the workaround can be dropped once a release containing it is out. The package now builds on Fedora 43, 44, 45 and rawhide, all architectures. Could you please take another look and re-review? Thanks! --- Spec URL: https://download.copr.fedorainfracloud.org/results/imbearchild/home/fedora-45-x86_64/11163993-kopia/kopia.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/imbearchild/home/srpm-builds/11163993/kopia-0.23.1-1.fc46.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/imbearchild/home/build/11163993/