Bug 2380549

Summary:	dlt-daemon: FTBFS with change proposal CMake 4.0
Product:	[Fedora] Fedora	Reporter:	Cristian Le <fedora>
Component:	dlt-daemon	Assignee:	Stephen John Smoogen <smooge>
Status:	CLOSED NOTABUG	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	smooge
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2025-07-30 17:09:46 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2376114

Description Cristian Le 2025-07-16 10:31:04 UTC

\
Dear package maintainer,

This is an automated bug created due to a FTBFS when rebuilding this package for the change proposal CMake 4.0.

The rebuild is being tracked in https://copr.fedorainfracloud.org/coprs/cmake-4.0.

See https://fedoraproject.org/wiki/Changes/CMake4.0 for more information on how to make the package compatible.

More specifically, depending on the state of the project:
- If it is actively maintained, please update the `cmake_minimum_required`, and instruct upstream to do so as well.
  To minimize future maintenance, please add a higher bound as well, preferrably with the highest CMake version being
  tested. You may use 4.0 as the higher bound as this is being tested in the tracked copr project.
- If the project is not maintained, you may add `CMAKE_POLICY_VERSION_MINIMUM=3.5` as a CMake variable or environment
  variable.

You can check the build locally following the instructions in the change proposal, or submit your build to the tracking
copr project.

Let me know if you encounter any issues, or need any other help.

Comment 1 Stephen John Smoogen 2025-07-30 16:59:48 UTC

I have added a patch to match the above and pushed to rawhide with dlt-daemon-2.18.10-6.fc43

Please check that this fixes the problem https://koji.fedoraproject.org/koji/taskinfo?taskID=135498229

Comment 2 Cristian Le 2025-07-30 17:09:46 UTC

If you ran a grep -R and made sure you patched all occurrences of `cmake_minimum_required` (there seem to be some in the examples, but maybe they are not being run), and it works with the current CMake, than all should be good. I run rebuilds periodically on the copr repo, so if anything is not right I will let you know. For now, thanks for patching.

Could you submit a patch to upstream, preferably with a higher-bound (`cmake_minimum_required(VERSION 3.3...4.0)`)

Comment 3 Stephen John Smoogen 2025-07-30 18:01:36 UTC

There is an existing upstream PR with https://github.com/COVESA/dlt-daemon/pull/755 which has been sitting waiting for a review. They usually wake up every 9 months or so.. so I am waiting to see how that one moves. Thanks