Bug 238133
| Summary: | Wrong init script | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Michal Marciniszyn <mmarcini> | ||||
| Component: | inn | Assignee: | Ondrej Vasik <ovasik> | ||||
| Status: | CLOSED ERRATA | QA Contact: | |||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 5.0 | CC: | rvokal, syeghiay, tvujec | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-10-15 15:00:38 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 237789, 238134 | ||||||
| Attachments: |
|
||||||
Created attachment 155158 [details]
Proposed patch
Please, try this patch and let me know.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux release. Since this bugzilla is in a component that is not approved for the current release, it has been closed with resolution deferred. You may reopen this bugzilla for consideration in the next release. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2008-0917.html |
Description of problem: In the innd script, there are several constructions that make it possible to end script with error code 0 while the service is not running. For example: [ "${NETWORKING}" = "no" ] && exit 0 [ -d /etc/news ] || exit 0 [ -f /etc/news/inn.conf ] || exit 0 . /usr/lib/news/lib/innshellvars || exit 0 [ -d "$SPOOLBASE" ] || exit 0 There is also minor error with incorrect error code of unimplemented script feature. Version-Release number of selected component (if applicable): all How reproducible: always Steps to Reproduce: 1. service network stop 2. service innd start/status 3. echo $? Actual results: 0 Expected results: correct error code/status code of the service Additional info: When fixing this bug, please obbey our init script guidelines and be sure that status command is run correctly. Our guidelines are on following two pages: http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html For an example of the script that returns the error codes correctly and always runs status see: http://devserv.devel.redhat.com/~mmarcini/amd This bug is tracked by 237789.