Bug 238238 (perl-Catalyst-Devel)
Summary: | Review Request: perl-Catalyst-Devel - Catalyst Development Tools | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | iarnell |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/Catalyst-Devel/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-08-10 23:52:01 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 238211, 238230, 238232, 238233, 238236 | ||
Bug Blocks: |
Description
Chris Weyl
2007-04-28 04:37:11 UTC
Whew, that should be the last of the "minimal" Catalyst modules needed. :) Please set the fedora-flag if you're reviewing this, thanks. add t/* to %doc ping? Pong :) SRPM URL: http://home.comcast.net/~ckweyl/perl-Catalyst-Devel-1.02-2.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Catalyst-Devel.spec Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 09dd471b600f4dddadc57ee5b56b2d02 Catalyst-Devel-1.02.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t t/01use............ok t/02pod............ok t/03podcoverage....ok All tests successful. Files=3, Tests=8, 1 wallclock secs ( 0.35 cusr + 0.05 csys = 0.40 CPU) + exit 0 + Provides: perl(Catalyst::Devel) = 1.02 perl(Catalyst::Helper) perl(Catalyst::Module::Install) perl(Module::Install::Catalyst) + Requires: /usr/bin/perl perl(:MODULE_COMPAT_5.8.8) perl(Catalyst) >= 5.7000 perl(Catalyst::Action::RenderView) >= 0.04 perl(Catalyst::Devel) perl(Catalyst::Exception) perl(Catalyst::Helper) perl(Catalyst::Manual) >= 5.7000 perl(Catalyst::Plugin::ConfigLoader) perl(Catalyst::Plugin::Static::Simple) >= 0.14 perl(Catalyst::Utils) perl(Class::Accessor::Fast) perl(Config) perl(File::Copy::Recursive) perl(File::Find) perl(File::Path) perl(File::Spec) perl(FindBin) perl(Getopt::Long) perl(IO::File) perl(Module::Install) >= 0.64 perl(Module::Install::Base) perl(POSIX) perl(Path::Class) >= 0.09 perl(Pod::Usage) perl(Template) perl(YAML) >= 0.55 perl(base) perl(strict) perl(warnings) APPROVED. New Package CVS Request ======================= Package Name: perl-Catalyst-Devel Short Description: Catalyst Development Tools Owners: cweyl.edu Branches: FC-6, F-7, devel InitialCC: fedora-perl-devel-list cvs done. Imported and building; thanks for the review! :) Package Change Request ====================== Package Name: perl-Catalyst-Devel New Branches: el6 Owners: iarnell tremble InitialCC: perl-sig Git done (by process-git-requests). |