SRPM URL: http://home.comcast.net/~ckweyl/perl-Catalyst-Plugin-SubRequest-0.11-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Catalyst-Plugin-SubRequest.spec Description: Make subrequests to actions in Catalyst. Uses the catalyst dispatcher, so it will work like an external url call.
make test failed in mock as PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01use............ok t/02subreq.........Can't locate HTTP/Request/AsCGI.pm in @INC (@INC contains: t/lib /builddir/build/BUILD/Catalyst-Plugin-SubRequest-0.11/blib/lib /builddir/build/BUILD/Catalyst-Plugin-SubRequest-0.11/blib/arch /usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.7/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.6/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.5/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.8 /usr/lib/perl5/site_perl/5.8.7 /usr/lib/perl5/site_perl/5.8.6 /usr/lib/perl5/site_perl/5.8.5 /usr/lib/perl5/site_perl /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.7/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.5/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.8 /usr/lib/perl5/vendor_perl/5.8.7 /usr/lib/perl5/vendor_perl/5.8.6 /usr/lib/perl5/vendor_perl/5.8.5 /usr/lib/perl5/vendor_perl /usr/lib/perl5/5.8.8/i386-linux-thread-multi /usr/lib/perl5/5.8.8 .) at /usr/lib/perl5/vendor_perl/5.8.8/Catalyst/Test.pm line 112. # Looks like your test died before it could output anything. dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED tests 1-9 Failed 9/9 tests, 0.00% okay t/03pod............ok t/04podcoverage....ok Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t/02subreq.t 255 65280 9 18 200.00% 1-9 Failed 1/4 test scripts, 75.00% okay. 9/12 subtests failed, 25.00% okay. make: *** [test_dynamic] Error 255 error: Bad exit status from /var/tmp/rpm-tmp.26634 (%check) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.26634 (%check)
I guess the spec should also BR perl(HTTP::Request::AsCGI)
Yep :) Sorry, this one fell under the radar for a while there.. SRPM URL: http://home.comcast.net/~ckweyl/perl-Catalyst-Plugin-SubRequest-0.11-2.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Catalyst-Plugin-SubRequest.spec
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 9b898321d80faf5df99df33f0ad632c3 Catalyst-Plugin-SubRequest-0.11.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01use............ok t/02subreq.........ok t/03pod............ok t/04podcoverage....ok All tests successful. Files=4, Tests=12, 1 wallclock secs ( 0.52 cusr + 0.09 csys = 0.61 CPU) + Provides: perl(Catalyst::Plugin::SubRequest) = 0.11 + Requires: perl(:MODULE_COMPAT_5.8.8) perl(Catalyst) perl(Catalyst) >= 5.00 perl(Time::HiRes) perl(strict) APPROVED.
New Package CVS Request ======================= Package Name: perl-Catalyst-Plugin-SubRequest Short Description: Make subrequests to actions in Catalyst Owners: cweyl.edu Branches: FC-5, FC-6, F-7, devel InitialCC: fedora-perl-devel-list
cvs done.
Imported and building. Thanks for the review! :)
Package Change Request ====================== Package Name: perl-Catalyst-Plugin-SubRequest New Branches: el6 Owners: iarnell tremble InitialCC: perl-sig
Git done (by process-git-requests).