Bug 2388595
| Summary: | Review Request: slimpris2 - MPRIS remote control of Lyrion Music Server | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Oliver <mavit> | ||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | benson_muite, package-review | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/mavit/slimpris2 | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Peter Oliver
2025-08-14 16:28:23 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9413322 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2388595-slimpris2/fedora-rawhide-x86_64/09413322-slimpris2/fedora-review/review.txt Found issues: - Systemd user unit service file(s) in slimpris2 Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Comments: a) Please use the %find_lang to find translations. See: https://docs.fedoraproject.org/en-US/package-maintainers/Packaging_Tutorial_2_GNU_Hello/#_translations b) Your fork has probably diverged from https://github.com/eonpatapon/mpDris2 but maybe good to check for any conflicts c) Consider using %forgesource macros: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ If not, please change Source0: %{url}/archive/refs/tags/%{version}.tar.gz#slimpris2-%{version}.tar.gz to Source0: %{url}/archive/%{version}/slimpris2-%{version}.tar.gz d) Please validate the desktop file https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files e) Please validate the appdata file https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ (In reply to Benson Muite from comment #2) > Comments: > a) Please use the %find_lang to find translations. See: > https://docs.fedoraproject.org/en-US/package-maintainers/ > Packaging_Tutorial_2_GNU_Hello/#_translations Done. > b) Your fork has probably diverged from > https://github.com/eonpatapon/mpDris2 > but maybe good to check for any conflicts Looks fine to me. > c) Consider using %forgesource macros: > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > > If not, please change > Source0: > %{url}/archive/refs/tags/%{version}.tar.gz#slimpris2-%{version}.tar.gz > to > Source0: %{url}/archive/%{version}/slimpris2-%{version}.tar.gz Done. > d) Please validate the desktop file > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files > > e) Please validate the appdata file > https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ These are covered by `make test`. Thanks for looking at this. SRPM URL: https://download.copr.fedorainfracloud.org/results/mavit/slimpris2/fedora-rawhide-x86_64/09440531-slimpris2/slimpris2-4.0.0-1.20250818git4.0.0.fc44.src.rpm Created attachment 2104039 [details]
The .spec file difference from Copr build 9413322 to 9440570
Copr build: https://copr.fedorainfracloud.org/coprs/build/9440570 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2388595-slimpris2/fedora-rawhide-x86_64/09440570-slimpris2/fedora-review/review.txt Found issues: - Systemd user unit service file(s) in slimpris2 Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. |