Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://raw.githubusercontent.com/mavit/slimpris2/refs/heads/release/slimpris2.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mavit/slimpris2/fedora-rawhide-x86_64/09413313-slimpris2/slimpris2-3.3.2-1.fc44.git.250.baad99a.src.rpm Description: slimpris2 provide MPRIS 2 remote control support for Lyrion Music Server, allowing it to be controlled using the user interface integrated into your desktop. Fedora Account System Username: mavit
Copr build: https://copr.fedorainfracloud.org/coprs/build/9413322 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2388595-slimpris2/fedora-rawhide-x86_64/09413322-slimpris2/fedora-review/review.txt Found issues: - Systemd user unit service file(s) in slimpris2 Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Comments: a) Please use the %find_lang to find translations. See: https://docs.fedoraproject.org/en-US/package-maintainers/Packaging_Tutorial_2_GNU_Hello/#_translations b) Your fork has probably diverged from https://github.com/eonpatapon/mpDris2 but maybe good to check for any conflicts c) Consider using %forgesource macros: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ If not, please change Source0: %{url}/archive/refs/tags/%{version}.tar.gz#slimpris2-%{version}.tar.gz to Source0: %{url}/archive/%{version}/slimpris2-%{version}.tar.gz d) Please validate the desktop file https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files e) Please validate the appdata file https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/
(In reply to Benson Muite from comment #2) > Comments: > a) Please use the %find_lang to find translations. See: > https://docs.fedoraproject.org/en-US/package-maintainers/ > Packaging_Tutorial_2_GNU_Hello/#_translations Done. > b) Your fork has probably diverged from > https://github.com/eonpatapon/mpDris2 > but maybe good to check for any conflicts Looks fine to me. > c) Consider using %forgesource macros: > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > > If not, please change > Source0: > %{url}/archive/refs/tags/%{version}.tar.gz#slimpris2-%{version}.tar.gz > to > Source0: %{url}/archive/%{version}/slimpris2-%{version}.tar.gz Done. > d) Please validate the desktop file > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files > > e) Please validate the appdata file > https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ These are covered by `make test`. Thanks for looking at this. SRPM URL: https://download.copr.fedorainfracloud.org/results/mavit/slimpris2/fedora-rawhide-x86_64/09440531-slimpris2/slimpris2-4.0.0-1.20250818git4.0.0.fc44.src.rpm
Created attachment 2104039 [details] The .spec file difference from Copr build 9413322 to 9440570
Copr build: https://copr.fedorainfracloud.org/coprs/build/9440570 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2388595-slimpris2/fedora-rawhide-x86_64/09440570-slimpris2/fedora-review/review.txt Found issues: - Systemd user unit service file(s) in slimpris2 Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.