Bug 2388965
| Summary: | Review Request: devedeng - A program to create video DVDs and CDs (VCD, sVCD or CVD) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andrea Musuruane <musuruan> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | benson_muite, ngompa13, package-review, philip.wyett |
| Target Milestone: | --- | Flags: | philip.wyett:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.rastersoft.com/programas/devede.html | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2218117 | ||
|
Description
Andrea Musuruane
2025-08-16 16:37:17 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9436528 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2388965-devedeng/fedora-rawhide-x86_64/09436528-devedeng/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'GPLv3'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Initial comments: a) Consider adding VCS: git:https://gitlab.com/rastersoft/devedeng.git b) Check with upstream if license should be GPL-3.0-only or GPL-3.0-or-later File headers seem to have had the "or later" removed incompletely: https://gitlab.com/rastersoft/devedeng/-/blob/master/src/devedeng/avbase.py?ref_type=heads#L9 c) Please ask upstream to block the name devedeng on PyPI https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_pypi_parity (In reply to Benson Muite from comment #2) > Initial comments: > a) Consider adding > VCS: git:https://gitlab.com/rastersoft/devedeng.git I will. > b) Check with upstream if license should be > GPL-3.0-only or GPL-3.0-or-later > File headers seem to have had the "or later" removed incompletely: > https://gitlab.com/rastersoft/devedeng/-/blob/master/src/devedeng/avbase. > py?ref_type=heads#L9 https://gitlab.com/rastersoft/devedeng/-/issues/101 > c) Please ask upstream to block the name devedeng on PyPI > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_pypi_parity https://gitlab.com/rastersoft/devedeng/-/issues/102 (In reply to Andrea Musuruane from comment #3) > (In reply to Benson Muite from comment #2) > > Initial comments: > > a) Consider adding > > VCS: git:https://gitlab.com/rastersoft/devedeng.git > > I will. Please don't. This tag is unused in Fedora. Hi, This submission has had no activity in some time. Are you waiting for additional review of submission already made or are yu working on a new one based o feedback you have already received? Regards Phil (In reply to Phil Wyett from comment #5) > Hi, > > This submission has had no activity in some time. Are you waiting for > additional review of > submission already made or are yu working on a new one based o feedback you > have already received? This review is stalled because I still haven't received any reply to: https://gitlab.com/rastersoft/devedeng/-/issues/102 |