Spec URL: https://raw.githubusercontent.com/rpmfusion/devedeng/56efa53090870fd418899f29a7c1bf7a8166c658/devedeng.spec SRPM URL: https://mirrors.neterra.net/rpmfusion/free/fedora/development/rawhide/Everything/source/SRPMS/d/devedeng-4.21.0-2.fc43.src.rpm Description: DevedeNG is a program to create video DVDs and CDs (VCD, sVCD or CVD), suitable for home players, from any number of video files, in any of the formats supported by FFMpeg. The suffix NG is because it is a rewrite from scratch of the old Devede, to work with Python3 and Gtk3, and with a new internal architecture that allows to expand it and easily add new features. Fedora Account System Username: musuruan This package is currently in RPM Fusion. I am the current maintainer. All devedeng's dependencies are in Fedora: https://bugzilla.rpmfusion.org/show_bug.cgi?id=7256
Copr build: https://copr.fedorainfracloud.org/coprs/build/9436528 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2388965-devedeng/fedora-rawhide-x86_64/09436528-devedeng/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'GPLv3'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Initial comments: a) Consider adding VCS: git:https://gitlab.com/rastersoft/devedeng.git b) Check with upstream if license should be GPL-3.0-only or GPL-3.0-or-later File headers seem to have had the "or later" removed incompletely: https://gitlab.com/rastersoft/devedeng/-/blob/master/src/devedeng/avbase.py?ref_type=heads#L9 c) Please ask upstream to block the name devedeng on PyPI https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_pypi_parity
(In reply to Benson Muite from comment #2) > Initial comments: > a) Consider adding > VCS: git:https://gitlab.com/rastersoft/devedeng.git I will. > b) Check with upstream if license should be > GPL-3.0-only or GPL-3.0-or-later > File headers seem to have had the "or later" removed incompletely: > https://gitlab.com/rastersoft/devedeng/-/blob/master/src/devedeng/avbase. > py?ref_type=heads#L9 https://gitlab.com/rastersoft/devedeng/-/issues/101 > c) Please ask upstream to block the name devedeng on PyPI > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_pypi_parity https://gitlab.com/rastersoft/devedeng/-/issues/102
(In reply to Andrea Musuruane from comment #3) > (In reply to Benson Muite from comment #2) > > Initial comments: > > a) Consider adding > > VCS: git:https://gitlab.com/rastersoft/devedeng.git > > I will. Please don't. This tag is unused in Fedora.