Bug 239163 (perl-Net-IPv6Addr)
| Summary: | Review Request: perl-Net-IPv6Addr - Perl module to check validity of IPv6 addresses | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sindre Pedersen Bjørdal <sindrepb> |
| Component: | Package Review | Assignee: | Chris Weyl <cweyl> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | cweyl:
fedora-review+
dennis: fedora-cvs+ |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-05-30 22:26:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 239159, 239895 | ||
| Bug Blocks: | 239162 | ||
|
Description
Sindre Pedersen Bjørdal
2007-05-05 13:34:24 UTC
*** Bug 239160 has been marked as a duplicate of this bug. *** This package has a prereq on Math::Base85, but Math::Base85 is currently not available in the fedora collection. This is needed both for certain features of this module as well as to fully enable the test suite. "Artistic or GPL" should be "GPL or Artistic".
Missing BRs on:
perl(Math::Base85)
perl(ExtUtils::MakeMaker)
Package should have an explicit "Requires: perl(Math::Base85)" as the dep is
not being picked up automagically.
There are a number of rfc docs included. Why not add these to %doc?
Make the above changes, and I'll approve. :)
+ source files match upstream:
cd06f0422ddb3ac119e2ef1e27aa9339 Net-IPv6Addr-0.2.tar.gz
cd06f0422ddb3ac119e2ef1e27aa9339 Net-IPv6Addr-0.2.tar.gz.srpm
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text not included upstream.
+ latest version is being packaged.
X BuildRequires are proper.
+ compiler flags are appropriate (noarch)
+ %clean is present.
+ package installs properly
+ rpmlint is silent.
X final provides and requires are sane:
** perl-Net-IPv6Addr-0.2-1.fc6.noarch.rpm
== rpmlint
== provides
perl(Net::IPv6Addr) = 0.2
perl-Net-IPv6Addr = 0.2-1.fc6
== requires
perl(:MODULE_COMPAT_5.8.8)
perl(Carp)
perl(Net::IPv4Addr)
perl(strict)
perl(vars)
+ %check is present and all tests pass:
All tests successful.
Files=9, Tests=287, 1 wallclock secs ( 0.70 cusr + 0.20 csys = 0.90 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.
Updated: - Fix license - Add explicit Requires on perl(Math::Base85) - Add missing BRs Spec URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Net-IPv6Addr.spec SRPM URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Net-IPv6Addr-0.2-3.fc7.src.rpm APPROVED New Package CVS Request ======================= Package Name: perl-Net-IPv6Addr Short Description: Perl module to check validity of IPv6 addresses Owners: foolish Branches: FC-6 F-7 EL-4 EL-5 cvs done |