Spec URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Net-IPv4Addr.spec SRPM URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Net-IPv4Addr-0.10-1.fc7.src.rpm Description: Net::IPv4Addr provides functions for parsing IPv4 addresses both in traditional address/netmask format and in the new CIDR format. There are also methods for calculating the network and broadcast address and also to see check if a given address is in a specific network.
Missing BR on perl(ExtUtils::MakeMaker) and perl(Test::More); License is (by convention) generally written as "GPL or Artistic", rather than the other way around. Make the above changes, and I'll approve :) + source files match upstream: 57aa8e28ebcd4c0c9f15792740e53d3c Net-IPv4Addr-0.10.tar.gz 57aa8e28ebcd4c0c9f15792740e53d3c ../Net-IPv4Addr-0.10.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate (noarch) + %clean is present. + package installs properly + rpmlint is silent. + final provides and requires are sane: ** perl=Net-IPv4Addr-0.10-1.fc6.noarch.rpm == rpmlint == provides perl(Net::IPv4Addr) = 0.10 perl-Net-IPv4Addr = 0.10-1.fc6 == requires /usr/bin/perl perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Getopt::Long) perl(Net::IPv4Addr) perl(strict) perl(vars) :lcheck is present and all tests pass + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app.
Updated SPEC: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Net-IPv4Addr.spec SRPM: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Net-IPv4Addr-0.10-2.fc7.src.rpm
APPROVED
New Package CVS Request ======================= Package Name: perl-Net-IPv4Addr Short Description: Perl extension for manipulating IPv4 addresses Owners: foolish Branches: FC-5 FC-6 EL-4 EL-5 InitialCC: jaa
cvs done
Seems the F7 branch wasn't created during merge, please add it. New Package CVS Request ======================= Package Name: perl-Net-IPv4Addr Short Description: Perl extension for manipulation IPv4 addresses Owners: foolish Branches: F-7
branched for F-7