Bug 239164 (perl-Net-SinFP)

Summary: Review Request: perl-Net-SinFP - Full operating system stack fingerprinting suite
Product: [Fedora] Fedora Reporter: Sindre Pedersen Bjørdal <sindrepb>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-06-05 20:33:50 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 239156, 239162, 376321    
Bug Blocks: 201449    

Description Sindre Pedersen Bjørdal 2007-05-05 09:41:29 EDT
Spec URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Net-SinFP.spec
SRPM URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Net-SinFP-2.06-1.fc7.src.rpm

SinFP is a full operating system stack fingerprinting suite which bypasses
limitations that nmap has. This approach brings the era of OS fingerprinting
on a per-TCP port basis, not on a per-host basis.
Comment 1 Jason Tibbitts 2007-06-10 01:06:35 EDT
This fails to build for me in rawhide due to a missing build dependency on
perl(ExtUtils::MakeMaker).  You also need build dependencies on Test::Pod and
Test::Pod::Coverage.  Having done that, rpmlint gives:
  W: perl-Net-SinFP unversioned-explicit-provides SinFP
which is something you'll have to filter.  cpanspec can do the filtering for you
with --filter-provides.

Also, the built package fails to install because nothing provides
perl(Net::Packet::Target).  I suppose Net::Package is expected to provide it,
but it doesn't.  Either that or rpm thinks this package needs it when it doesn't.
Comment 2 Jason Tibbitts 2007-06-27 21:00:47 EDT
Ping?  This is blocked on perl-Net-Packet, which has been approved for some time
but not imported yet.  Is there any chance we could move forward soon?
Comment 3 Jason Tibbitts 2007-07-27 22:02:56 EDT
perl-Net-Packet is in rawhide now, so this could be built, but the issues in
comment #1 still apply.
Comment 4 Jason Tibbitts 2007-09-05 19:19:56 EDT
This has been needinfo for ages now; is anything ever going to happen with this
Comment 5 Sindre Pedersen Bjørdal 2007-11-11 15:21:39 EST
Bringing this one back, 


- Add missing BRs: perl(ExtUtils::MakeMaker), perl(Test::Pod),
perl(Test::Pod::Coverage) and perl(Net::Packet::Target) (see
- Update License tag

Comment 6 Sindre Pedersen Bjørdal 2007-11-12 19:25:59 EST
perl-Net-Packet-Target now in devel and updates for F-8 and F-7 are pending.
Shall we proceed?
Comment 7 Jason Tibbitts 2007-11-14 20:39:07 EST
Fails to build for me, due to a failure in %check:

t/01-use.............Can't locate Net/Packet/Consts.pm in @INC (@INC contains:...)

Looks like you need a build dependency on perl(Net::Packet).  Adding that gets
everything building; I'll assume it's there for the purposes of this review.

rpmlint says:
  perl-Net-SinFP.src:4: W: unversioned-explicit-provides SinFP
It would be best if you provided a version here:
  Provides: SinFP = %{version}-%{release}

Now I see a rather significant problem: the License.  The both README and
LICENSE in this package pretty clearly say "Artistic License" which would render
this package unacceptable for Fedora.  You have "GPL+ or Artistic" in your
License: tag; do you have some other source for this package being under the GPL?
Comment 8 Jason Tibbitts 2007-11-14 20:43:14 EST
BTW, if this really is just Artistic, perhaps upstream would be willing to
relicense under the Perl license or one of the revised/clarified Artistic
variants, all of which are acceptable for Fedora.
Comment 9 Sindre Pedersen Bjørdal 2007-11-14 21:13:50 EST
I wasn't aware that Artistic was unacceptable. Sent an email to the upstream
developer asking about the license and if he's willing to change it. Guess this
package has to wait a little bit longer.
Comment 10 Jason Tibbitts 2008-01-18 23:22:52 EST
Any progress?
Comment 11 Sindre Pedersen Bjørdal 2008-01-19 04:18:22 EST
Here's the response I got from upstream

"In short, no GPL for my modules. Concerning the upgrade to Artistic v2, 
I will see that when I will update my modules, because I will not 
issue an update just for a distribution issue.

CPAN is the way to install modules anyway."
Comment 12 Jason Tibbitts 2008-01-19 11:43:22 EST
Hilarious.  That comment belies such significant ignorance.

In any case, he doesn't actually have to issue updates; he just needs to provide
you with an email which permits us to use and distribute under the terms of
Artistic v2.  You can include that email in the package as documentation and
it's OK.
Comment 13 Sindre Pedersen Bjørdal 2008-01-24 07:52:54 EST
Comment 14 Jason Tibbitts 2008-03-02 17:58:39 EST
Any update?
Comment 15 Jason Tibbitts 2008-04-04 14:54:32 EDT
I guess it's time for another monthly ping on this ticket.  Is there any chance
that this could move forward?
Comment 16 Jason Tibbitts 2008-05-10 18:48:50 EDT
Looks like there's not been any progress.  Setting NEEDINFO; I'll close this
soon if nothing happens.