Bug 376321 - Review Request: perl-Net-Packet-Target - An object for all network related stuff
Summary: Review Request: perl-Net-Packet-Target - An object for all network related stuff
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: perl-Net-SinFP
TreeView+ depends on / blocked
 
Reported: 2007-11-11 19:01 UTC by Sindre Pedersen Bjørdal
Modified: 2007-11-30 22:12 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2007-11-13 00:19:48 UTC
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Sindre Pedersen Bjørdal 2007-11-11 19:01:41 UTC
Spec URL: http://sindrepb.fedorapeople.org/packages/perl-Net-SinFP/perl-Net-Packet-Target.spec
SRPM URL: http://sindrepb.fedorapeople.org/packages/perl-Net-SinFP/perl-Net-Packet-Target-1.01-1.fc8.src.rpm

Description:

perl-Net-Packet-Target is an object for all network related stuff

Comment 1 Parag AN(पराग) 2007-11-12 10:23:27 UTC
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
7165c14c0cd02ec082c27b05a9ba5874  Net-Packet-Target-1.01.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
t/01-pod-coverage....ok
t/01-test-pod........ok
t/01-use.............ok
All tests successful.
Files=3, Tests=3,  0 wallclock secs ( 0.30 cusr +  0.05 csys =  0.35 CPU)
+ Package perl-Net-Packet-Target-1.01-1.fc8 ->
  Provides: perl(Net::Packet::Target) = 1.01
  Requires: perl(:MODULE_COMPAT_5.8.8) perl(Class::Gomor::Array) perl(strict)
perl(warnings)

APPROVED.


Comment 2 Sindre Pedersen Bjørdal 2007-11-12 20:26:06 UTC
New Package CVS Request
=======================
Package Name: perl-Net-Packet-Target
Short Description: An object for all network related stuff
Owners: sindrepb
Branches: F-7, F-8 
InitialCC: 
Cvsextras Commits: yes

Comment 3 Kevin Fenzi 2007-11-12 21:47:51 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.