Bug 2394056
| Summary: | Review Request: python-urllib3-epel - EPEL packages with Python extras for python-urllib3 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro HronÄok <mhroncok> |
| Component: | Package Review | Assignee: | Carl George š© <carl> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | carl, package-review |
| Target Milestone: | --- | Flags: | carl:
fedora-review+
fedora-admin-xmlrpc: mirror+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-09-26 02:13:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2393034 | ||
|
Description
Miro HronÄok
2025-09-09 12:15:13 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9539684 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2394056-python-urllib3-epel/fedora-rawhide-x86_64/09539684-python-urllib3-epel/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. This is blocked on python-pytest-freezegun. That package is mine and I can branch it in epel10. I also opened https://src.fedoraproject.org/rpms/python-rpm-macros/pull-request/194 so I can get rid of the ugly %gsub one day. (In reply to Miro HronÄok from comment #2) > This is blocked on python-pytest-freezegun. That package is mine and I can > branch it in epel10. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-9067102bef sdie tag scratchbuild: https://koji.fedoraproject.org/koji/taskinfo?taskID=136947215 FYI, this does qualify for a review exception under the third bullet point here: https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/#_package_review_exceptions That said, I'm happy to review the specific aspects of making this one of these special epel-only packages. The gsub trick is neat, it almost feels like too much magic, but I can understand the preference of doing that over listing out all the subpackages manually just to change the requires. I'm looking forward to using the %python_extras_subpkg -v in the future. Everything else checks out: * no source or binary package name conflict with CentOS/RHEL * no file conflicts with CentOS/RHEL * no obsoletes or provides of CentOS/RHEL packages To the extent I can approve a package that qualifies for a review exception, PACKAGE APPROVED. FEDORA-EPEL-2025-d28b99290e (python-urllib3-epel-1.26.19-2.el10_2) has been submitted as an update to Fedora EPEL 10.2. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-d28b99290e FEDORA-EPEL-2025-d28b99290e has been pushed to the Fedora EPEL 10.2 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-d28b99290e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2025-d28b99290e (python-urllib3-epel-1.26.19-2.el10_2) has been pushed to the Fedora EPEL 10.2 stable repository. If problem still persists, please make note of it in this bug report. |