Bug 2394056 - Review Request: python-urllib3-epel - EPEL packages with Python extras for python-urllib3
Summary: Review Request: python-urllib3-epel - EPEL packages with Python extras for py...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Carl George 🎩
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2393034
TreeView+ depends on / blocked
 
Reported: 2025-09-09 12:15 UTC by Miro Hrončok
Modified: 2025-09-26 02:13 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-09-26 02:13:29 UTC
Type: ---
Embargoed:
carl: fedora-review+
fedora-admin-xmlrpc: mirror+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Fedora Package Sources python-urllib3-epel pull-request 1 0 None None None 2025-09-11 10:47:19 UTC
Red Hat Issue Tracker FC-2187 0 None None None 2025-09-09 14:42:13 UTC

Description Miro Hrončok 2025-09-09 12:15:13 UTC
Spec URL: https://churchyard.fedorapeople.org/python-urllib3-epel.spec
SRPM URL: https://churchyard.fedorapeople.org/python-urllib3-epel-1.26.19-2.el10_2.src.rpm

Description:
This package exists to build metapackages with missing urllib3 extras in EPEL.

Fedora Account System Username: churchyard

Comment 1 Fedora Review Service 2025-09-09 12:24:41 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9539684
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2394056-python-urllib3-epel/fedora-rawhide-x86_64/09539684-python-urllib3-epel/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Miro Hrončok 2025-09-09 12:59:42 UTC
This is blocked on python-pytest-freezegun. That package is mine and I can branch it in epel10.

Comment 3 Miro Hrončok 2025-09-09 13:03:19 UTC
I also opened https://src.fedoraproject.org/rpms/python-rpm-macros/pull-request/194 so I can get rid of the ugly %gsub one day.

Comment 4 Miro Hrončok 2025-09-09 13:35:49 UTC
(In reply to Miro Hrončok from comment #2)
> This is blocked on python-pytest-freezegun. That package is mine and I can
> branch it in epel10.

https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-9067102bef

Comment 5 Miro Hrončok 2025-09-09 13:59:16 UTC
sdie tag scratchbuild: https://koji.fedoraproject.org/koji/taskinfo?taskID=136947215

Comment 6 Carl George 🎩 2025-09-11 06:05:39 UTC
FYI, this does qualify for a review exception under the third bullet point here:

https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/#_package_review_exceptions

That said, I'm happy to review the specific aspects of making this one of these special epel-only packages.

The gsub trick is neat, it almost feels like too much magic, but I can understand the preference of doing that over listing out all the subpackages manually just to change the requires.  I'm looking forward to using the %python_extras_subpkg -v in the future.

Everything else checks out:

* no source or binary package name conflict with CentOS/RHEL
* no file conflicts with CentOS/RHEL
* no obsoletes or provides of CentOS/RHEL packages

To the extent I can approve a package that qualifies for a review exception, PACKAGE APPROVED.

Comment 8 Fedora Update System 2025-09-17 15:54:18 UTC
FEDORA-EPEL-2025-d28b99290e (python-urllib3-epel-1.26.19-2.el10_2) has been submitted as an update to Fedora EPEL 10.2.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-d28b99290e

Comment 9 Fedora Update System 2025-09-18 01:57:49 UTC
FEDORA-EPEL-2025-d28b99290e has been pushed to the Fedora EPEL 10.2 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-d28b99290e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2025-09-26 02:13:29 UTC
FEDORA-EPEL-2025-d28b99290e (python-urllib3-epel-1.26.19-2.el10_2) has been pushed to the Fedora EPEL 10.2 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.