Bug 2398054

Summary: Review Request: rust-quote-use-macros - Support use in procmacros hygienically
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/quote-use-macros
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-10-02 10:43:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2398050    
Bug Blocks: 2398057    
Attachments:
Description Flags
Configuration file for rust2rpm none

Description Ben Beasley 2025-09-25 09:18:19 UTC
Created attachment 2107537 [details]
Configuration file for rust2rpm

Spec URL: https://music.fedorapeople.org/rust-quote-use-macros.spec
SRPM URL: https://music.fedorapeople.org/rust-quote-use-macros-0.8.4-1.fc42.src.rpm
Description: Support `use` in procmacros hygienically.
Fedora Account System Username: music

This is a new indirect dependency for ruff 0.12.2 and later.

Comment 1 Ben Beasley 2025-09-25 09:19:11 UTC
COPR build with fedora-review enabled: https://copr.fedorainfracloud.org/coprs/build/9599978

Comment 2 Fedora Review Service 2025-09-25 09:21:22 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9599980
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2398054-rust-quote-use-macros/fedora-rawhide-x86_64/09599980-rust-quote-use-macros/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2025-09-25 09:21:25 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9599979
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2398054-rust-quote-use-macros/fedora-rawhide-x86_64/09599979-rust-quote-use-macros/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2025-10-02 10:17:44 UTC
Package was generated with rust2rpm, simplifying the review.

The PR to add the license text upstream was merged, so including it manually is OK for now.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
   (included manually from upstream; PR to include text in repo and published crates submitted and already merged)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 5 Ben Beasley 2025-10-02 10:21:38 UTC
Thank you for the review!

https://release-monitoring.org/project/385427/

Comment 6 Fedora Admin user for bugzilla script actions 2025-10-02 10:22:12 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-quote-use-macros

Comment 7 Fedora Update System 2025-10-02 10:38:49 UTC
FEDORA-2025-c1f9d96bc2 (rust-quote-use-macros-0.8.4-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-c1f9d96bc2

Comment 8 Fedora Update System 2025-10-02 10:43:28 UTC
FEDORA-2025-c1f9d96bc2 (rust-quote-use-macros-0.8.4-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.