Bug 2398057 - Review Request: rust-quote-use - Support use in procmacros hygienically
Summary: Review Request: rust-quote-use - Support use in procmacros hygienically
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/quote-use
Whiteboard:
Depends On: 2398054
Blocks: 2398120
TreeView+ depends on / blocked
 
Reported: 2025-09-25 09:34 UTC by Ben Beasley
Modified: 2025-10-04 07:09 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-10-04 07:09:37 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
Configuration file for rust2rpm (762 bytes, text/plain)
2025-09-25 09:34 UTC, Ben Beasley
no flags Details

Description Ben Beasley 2025-09-25 09:34:13 UTC
Created attachment 2107541 [details]
Configuration file for rust2rpm

Spec URL: https://music.fedorapeople.org/rust-quote-use.spec
SRPM URL: https://music.fedorapeople.org/rust-quote-use0.8.4-1.fc42.src.rpm
Description: Support `use` in procmacros hygienically.
Fedora Account System Username: music

This is a new indirect dependency for ruff 0.12.2 and later.

COPR build with fedora-review enabled: https://copr.fedorainfracloud.org/coprs/build/9599997

Comment 1 Fedora Review Service 2025-09-25 09:34:20 UTC
There seems to be some problem with the following file.
SRPM URL: https://music.fedorapeople.org/rust-quote-use0.8.4-1.fc42.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fedora Review Service 2025-09-25 09:34:22 UTC
There seems to be some problem with the following file.
SRPM URL: https://music.fedorapeople.org/rust-quote-use0.8.4-1.fc42.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fedora Review Service 2025-09-25 09:37:14 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9600006
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2398057-rust-quote-use/fedora-rawhide-x86_64/09600006-rust-quote-use/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fabio Valentini 2025-10-03 21:37:58 UTC
Package was generated with rust2rpm, simplifying the review.

✅❌❓🫤

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
   (manually included from upstream - PR to include a license text was submitted and already merged,
   so the reference could actually already be changed from the file in the PR to the file at the project's git HEAD)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 6 Ben Beasley 2025-10-04 06:54:17 UTC
Thank you for the review!

(In reply to Fabio Valentini from comment #5)
> ✅ license file is included with %license in %files
>    (manually included from upstream - PR to include a license text was
> submitted and already merged,
>    so the reference could actually already be changed from the file in the
> PR to the file at the project's git HEAD)

The commit/URL https://github.com/ModProg/quote-use/raw/e4b59902f6af22b8317714e4e7ec695c0fc9e621/LICENSE, originally from the PR, actually does now appear in the history of main, https://github.com/ModProg/quote-use/commits/main/. I could have referenced the subsequent merge commit https://github.com/ModProg/quote-use/commit/c6cc1e494ea42ca93be7baaa70efe0ad21414019 instead, but the effect would be the same.

https://release-monitoring.org/project/385455/

Comment 7 Fedora Admin user for bugzilla script actions 2025-10-04 06:55:00 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-quote-use

Comment 8 Fedora Update System 2025-10-04 07:07:22 UTC
FEDORA-2025-d1f2e8c1d9 (rust-quote-use-0.8.4-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-d1f2e8c1d9

Comment 9 Fedora Update System 2025-10-04 07:09:37 UTC
FEDORA-2025-d1f2e8c1d9 (rust-quote-use-0.8.4-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.