Bug 2398057
| Summary: | Review Request: rust-quote-use - Support use in procmacros hygienically | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/quote-use | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-10-04 07:09:37 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2398054 | ||||||
| Bug Blocks: | 2398120 | ||||||
| Attachments: |
|
||||||
|
Description
Ben Beasley
2025-09-25 09:34:13 UTC
There seems to be some problem with the following file. SRPM URL: https://music.fedorapeople.org/rust-quote-use0.8.4-1.fc42.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. There seems to be some problem with the following file. SRPM URL: https://music.fedorapeople.org/rust-quote-use0.8.4-1.fc42.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Typo fix: Spec URL: https://music.fedorapeople.org/rust-quote-use.spec SRPM URL: https://music.fedorapeople.org/rust-quote-use-0.8.4-1.fc42.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/9600006 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2398057-rust-quote-use/fedora-rawhide-x86_64/09600006-rust-quote-use/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. ✅❌❓🫤 ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files (manually included from upstream - PR to include a license text was submitted and already merged, so the reference could actually already be changed from the file in the PR to the file at the project's git HEAD) - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) Thank you for the review! (In reply to Fabio Valentini from comment #5) > ✅ license file is included with %license in %files > (manually included from upstream - PR to include a license text was > submitted and already merged, > so the reference could actually already be changed from the file in the > PR to the file at the project's git HEAD) The commit/URL https://github.com/ModProg/quote-use/raw/e4b59902f6af22b8317714e4e7ec695c0fc9e621/LICENSE, originally from the PR, actually does now appear in the history of main, https://github.com/ModProg/quote-use/commits/main/. I could have referenced the subsequent merge commit https://github.com/ModProg/quote-use/commit/c6cc1e494ea42ca93be7baaa70efe0ad21414019 instead, but the effect would be the same. https://release-monitoring.org/project/385455/ The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-quote-use FEDORA-2025-d1f2e8c1d9 (rust-quote-use-0.8.4-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-d1f2e8c1d9 FEDORA-2025-d1f2e8c1d9 (rust-quote-use-0.8.4-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report. |