Bug 2398120

Summary: Review Request: rust-attribute-derive-macro - Clap for proc macro attributes
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/attribute-derive-macro
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-10-11 20:42:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2398050, 2398057, 2398062, 2398064, 2398112    
Bug Blocks: 2398133    

Description Ben Beasley 2025-09-25 12:28:24 UTC
Spec URL: https://music.fedorapeople.org/rust-attribute-derive-macro.spec
SRPM URL: https://music.fedorapeople.org/rust-attribute-derive-macro-0.10.3-1.fc42.src.rpm
Description: Clap for proc macro attributes.
Fedora Account System Username: music

This is a new indirect dependency for ruff 0.12.2 and later.

Comment 1 Fedora Review Service 2025-09-25 12:28:37 UTC
There seems to be some problem with the following file.
SRPM URL: https://music.fedorapeople.org/rust-attribute-derive-macro-0.10.3-1.fc42.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Ben Beasley 2025-09-25 12:33:57 UTC
[fedora-review-service-build]

COPR build with fedora-review enabled: https://copr.fedorainfracloud.org/coprs/build/9600587

Comment 3 Fedora Review Service 2025-09-25 12:37:14 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9600625
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2398120-rust-attribute-derive-macro/fedora-rawhide-x86_64/09600625-rust-attribute-derive-macro/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2025-10-11 18:08:44 UTC
Package was generated with rust2rpm, simplifying the review.

Version 0.10.4 and 0.10.5 have been released with no changes other than a small code change, it should hopefully be straightforward to update to 0.10.5.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
🫤 latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 5 Ben Beasley 2025-10-11 20:26:52 UTC
Thank you for the review!

https://release-monitoring.org/project/386117/

It looks like there were no changes at all in 0.10.5 in either crate except for the version of the dependency on attribute-derive-macro from attribute-derive. Still, I’ll go ahead and update.

Comment 6 Fedora Admin user for bugzilla script actions 2025-10-11 20:28:06 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-attribute-derive-macro

Comment 7 Fedora Update System 2025-10-11 20:40:20 UTC
FEDORA-2025-c02040f37d (rust-attribute-derive-macro-0.10.5-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-c02040f37d

Comment 8 Fedora Update System 2025-10-11 20:42:36 UTC
FEDORA-2025-c02040f37d (rust-attribute-derive-macro-0.10.5-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.