Bug 2404632
| Summary: | Review Request: intel-metrics-discovery - Shared library for Intel Metrics Discovery API | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | pavel.androniychuk | ||||
| Component: | Package Review | Assignee: | Simone Caronni <negativo17> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | negativo17:
fedora-review+
|
||||
| Hardware: | Unspecified | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/intel/metrics-discovery | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-10-21 21:18:40 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
pavel.androniychuk
2025-10-16 23:07:43 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9696634 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2404632-intel-metrics-discovery/fedora-rawhide-x86_64/09696634-intel-metrics-discovery/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Please perform the following changes: - Drop the Group (Obsolete) and %defattr directives (default) - Adjust the devel subpackage description - List explicitly the shared object major versions in the %files section, this prevents accidental unnoticed bumps that might require rebuild all dependent packages in a rush. - Add ExclusiveArch: x86_64 as it does not build on aarch64 or others - Align descriptions to 80 characters (optional) Sample diff: $ diff -Naur intel-metrics-discovery.spec intel-metrics-discovery.spec.new --- intel-metrics-discovery.spec 2025-10-16 23:14:52.000000000 +0200 +++ intel-metrics-discovery.spec.new 2025-10-17 13:30:48.810080928 +0200 @@ -4,8 +4,9 @@ Version: 1.14.182 Release: %autorelease Summary: Shared library for Intel Metrics Discovery API -Group: System Environment/Libraries License: MIT +ExclusiveArch: x86_64 + URL: https://github.com/intel/metrics-discovery Source0: %{url}/archive/%{upstream_name}-%{version}.tar.gz @@ -16,19 +17,17 @@ BuildRequires: libdrm-devel %description -Intel Metrics Discovery Application Programming Interface creates an -abstraction level between Intel graphics hardware and applications, providing -access to detailed GPU performance data. +Intel Metrics Discovery Application Programming Interface creates an abstraction +level between Intel graphics hardware and applications, providing access to +detailed GPU performance data. %package devel Summary: Development files for %{name} Requires: %{name} = %{version}-%{release} %description devel -Intel Metrics Discovery Application Programming Interface creates an -abstraction level between Intel graphics hardware and applications, providing -access to detailed GPU performance data. - +The %{name}-devel package contains libraries and header files for +developing applications that use %{name}. %prep %autosetup -n %{upstream_name}-%{upstream_name}-%{version} @@ -44,19 +43,17 @@ %cmake_install %files -%defattr(-,root,root,-) %config(noreplace) -%{_libdir}/libigdmd.so.* +%{_libdir}/libigdmd.so.%{version} +%{_libdir}/libigdmd.so.1 %license LICENSE.md %doc README.md %files devel -%defattr(-,root,root,-) %config(noreplace) %{_libdir}/libigdmd.so %{_includedir}/metrics_discovery_api.h %{_libdir}/pkgconfig/libigdmd.pc - %changelog %autochangelog After the changes above, package will be approved. Thanks! Applied above changes. Successful build here https://copr.fedorainfracloud.org/coprs/androniychuk/intel-metrics-discovery/build/9700198/ SPEC Url: https://download.copr.fedorainfracloud.org/results/androniychuk/intel-metrics-discovery/fedora-rawhide-x86_64/09700198-intel-metrics-discovery/intel-metrics-discovery.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/androniychuk/intel-metrics-discovery/fedora-rawhide-x86_64/09700198-intel-metrics-discovery/intel-metrics-discovery-1.14.182-1.fc44.src.rpm Created attachment 2110253 [details]
The .spec file difference from Copr build 9696634 to 9706701
Copr build: https://copr.fedorainfracloud.org/coprs/build/9706701 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2404632-intel-metrics-discovery/fedora-rawhide-x86_64/09706701-intel-metrics-discovery/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package approved. Thanks. The Pagure repository was created at https://src.fedoraproject.org/rpms/intel-metrics-discovery FEDORA-2025-4f94717cf4 (intel-metrics-discovery-1.14.182-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-4f94717cf4 FEDORA-2025-4f94717cf4 (intel-metrics-discovery-1.14.182-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report. |