Bug 2404632 - Review Request: intel-metrics-discovery - Shared library for Intel Metrics Discovery API
Summary: Review Request: intel-metrics-discovery - Shared library for Intel Metrics Di...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Simone Caronni
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/intel/metrics-disc...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-10-16 23:07 UTC by pavel.androniychuk
Modified: 2025-10-21 21:18 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-10-21 21:18:40 UTC
Type: ---
Embargoed:
negativo17: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 9696634 to 9706701 (1.94 KB, patch)
2025-10-20 16:49 UTC, Fedora Review Service
no flags Details | Diff

Comment 1 Fedora Review Service 2025-10-17 00:17:20 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9696634
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2404632-intel-metrics-discovery/fedora-rawhide-x86_64/09696634-intel-metrics-discovery/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Simone Caronni 2025-10-17 11:33:38 UTC
Please perform the following changes:

- Drop the Group (Obsolete) and %defattr directives (default)
- Adjust the devel subpackage description
- List explicitly the shared object major versions in the %files section, this prevents accidental unnoticed bumps that might require rebuild all dependent packages in a rush.
- Add ExclusiveArch: x86_64 as it does not build on aarch64 or others
- Align descriptions to 80 characters (optional)

Comment 3 Simone Caronni 2025-10-17 11:34:00 UTC
Sample diff:

$ diff -Naur intel-metrics-discovery.spec intel-metrics-discovery.spec.new 
--- intel-metrics-discovery.spec	2025-10-16 23:14:52.000000000 +0200
+++ intel-metrics-discovery.spec.new	2025-10-17 13:30:48.810080928 +0200
@@ -4,8 +4,9 @@
 Version: 1.14.182
 Release: %autorelease
 Summary: Shared library for Intel Metrics Discovery API
-Group: System Environment/Libraries
 License: MIT
+ExclusiveArch: x86_64
+
 URL: https://github.com/intel/metrics-discovery
 Source0: %{url}/archive/%{upstream_name}-%{version}.tar.gz
 
@@ -16,19 +17,17 @@
 BuildRequires: libdrm-devel
 
 %description
-Intel Metrics Discovery Application Programming Interface creates an
-abstraction level between Intel graphics hardware and applications, providing
-access to detailed GPU performance data.
+Intel Metrics Discovery Application Programming Interface creates an abstraction
+level between Intel graphics hardware and applications, providing access to
+detailed GPU performance data.
 
 %package         devel
 Summary:         Development files for %{name}
 Requires:        %{name} = %{version}-%{release}
 
 %description     devel
-Intel Metrics Discovery Application Programming Interface creates an
-abstraction level between Intel graphics hardware and applications, providing
-access to detailed GPU performance data.
-
+The %{name}-devel package contains libraries and header files for
+developing applications that use %{name}.
 
 %prep
 %autosetup -n %{upstream_name}-%{upstream_name}-%{version}
@@ -44,19 +43,17 @@
 %cmake_install
 
 %files
-%defattr(-,root,root,-)
 %config(noreplace)
-%{_libdir}/libigdmd.so.*
+%{_libdir}/libigdmd.so.%{version}
+%{_libdir}/libigdmd.so.1
 %license LICENSE.md
 %doc README.md
 
 %files devel
-%defattr(-,root,root,-)
 %config(noreplace)
 %{_libdir}/libigdmd.so
 %{_includedir}/metrics_discovery_api.h
 %{_libdir}/pkgconfig/libigdmd.pc
 
-
 %changelog
 %autochangelog

Comment 4 Simone Caronni 2025-10-17 11:34:17 UTC
After the changes above, package will be approved. Thanks!

Comment 5 pavel.androniychuk 2025-10-17 16:32:59 UTC
Applied above changes.
Successful build here
https://copr.fedorainfracloud.org/coprs/androniychuk/intel-metrics-discovery/build/9700198/

Comment 7 Fedora Review Service 2025-10-20 16:49:00 UTC
Created attachment 2110253 [details]
The .spec file difference from Copr build 9696634 to 9706701

Comment 8 Fedora Review Service 2025-10-20 16:49:02 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9706701
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2404632-intel-metrics-discovery/fedora-rawhide-x86_64/09706701-intel-metrics-discovery/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Simone Caronni 2025-10-20 16:57:18 UTC
Package approved. Thanks.

Comment 10 Fedora Admin user for bugzilla script actions 2025-10-21 20:31:01 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/intel-metrics-discovery

Comment 11 Fedora Update System 2025-10-21 21:13:43 UTC
FEDORA-2025-4f94717cf4 (intel-metrics-discovery-1.14.182-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-4f94717cf4

Comment 12 Fedora Update System 2025-10-21 21:18:40 UTC
FEDORA-2025-4f94717cf4 (intel-metrics-discovery-1.14.182-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.