Bug 241472
Summary: | Review Request: ocaml-ocamlnet - Network protocols for OCaml | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Richard W.M. Jones <rjones> |
Component: | Package Review | Assignee: | Xavier Lamien <lxtnow> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | lxtnow:
fedora-review+
kevin: fedora-cvs+ |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-12-06 17:09:14 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 241476, 241487, 435286 |
Description
Richard W.M. Jones
2007-05-26 10:52:54 UTC
Spec URL: http://annexia.org/tmp/ocaml-ocamlnet.spec SRPM URL: http://annexia.org/tmp/ocaml-ocamlnet-2.2.7-3.src.rpm Updated to remove empty file rpc-generator/dummy.mli, which Gerd Stoplmann assures me is not needed. Please note that rpmlint issues some warnings here: (1) devel-file-in-non-devel-package: see Bug 241471. (2) unstripped-binary-or-object: you mustn't try to strip OCaml bytecode binaries, because stripping them removes the bytecode, and they no longer run. (3) configure-without-libdir-spec: irrelevant because this isn't an autoconf-generated configure Spec URL: http://annexia.org/tmp/ocaml-ocamlnet.spec SRPM URL: http://annexia.org/tmp/ocaml-ocamlnet-2.2.7-4.src.rpm Updated to support ocaml-lablgtk2 package (see bug 241696). Xavier, If you're going to review this and other ocaml packages you've assigned to yourself, please set the fedora-review flag to '?'. Thanks. Starting review... This package has a dependency on ocaml-findlib-devel too. Adding the dependency bug #240557 This bug dependency must be approved and imported in order to make me able to finalize and approve this one. Spec URL: http://annexia.org/tmp/ocaml/ocaml-ocamlnet.spec SRPM URL: http://annexia.org/tmp/ocaml/ocaml-ocamlnet-2.2.7-5.src.rpm Updated to latest OCaml packaging guidelines. Built against OCaml 3.10. Tested against bytecode-only architectures. Starting review... Xavier: I just tried to build ocamlnet now and this package seems to have suffered some bit-rot. There's a camlp4 problem in particular which I've asked about upstream. So you might want to leave this alone for now... ping Richard ? Any news about this issue ? The news is that I really must get around to fixing this package :-) Debian have fixed it, so I'll just copy their fix. http://pkg-ocaml-maint.alioth.debian.org/debian-ocaml-status.html I've got a bunch of real easy reviews waiting! Bug 253564 Bug 253570 Bug 253571 Bug 275491 Spec URL: http://annexia.org/tmp/ocaml/ocaml-ocamlnet.spec SRPM URL: http://annexia.org/tmp/ocaml/ocaml-ocamlnet-2.2.8.1-1.src.rpm * Thu Sep 13 2007 Richard W.M. Jones <rjones> - 2.2.8.1-1 - New upstream version 2.2.8.1. - License of the base package is in fact BSD. Clarified also that the license of nethttpd is GPLv2+. - Removed the camlp4 paths patch as it doesn't seem to be necessary. - Add BRs for camlp4, ocaml-pcre-devel, ocaml-lablgtk-devel, openssl-devel - Removed explicit requires, they're not needed. - Strip binaries and libraries. - Ignore Parsetree module in deps. * Thu Aug 2 2007 Richard W.M. Jones <rjones> - 2.2.7-6 - ExcludeArch ppc64 - BR ocaml-pcre-devel - Fix for camlp4 missing path I forgot to add that rpmlint on the above package will complain with error messages like this: ocaml-ocamlnet-nethttpd.x86_64: E: useless-explicit-provides ocaml(Nethttpd_engine) However this is not an error. The package provides two sets of modules with the same name but different implementations, which can be selected separately with ocamlfind when linking. # rpm -qlp ocaml-ocamlnet-nethttpd-2.2.8.1-1.x86_64.rpm /usr/lib64/ocaml/nethttpd /usr/lib64/ocaml/nethttpd-for-netcgi1 /usr/lib64/ocaml/nethttpd-for-netcgi1/META /usr/lib64/ocaml/nethttpd-for-netcgi1/nethttpd-for-netcgi1.cma /usr/lib64/ocaml/nethttpd-for-netcgi1/nethttpd_engine.cmi [...] /usr/lib64/ocaml/nethttpd-for-netcgi2 /usr/lib64/ocaml/nethttpd-for-netcgi2/META /usr/lib64/ocaml/nethttpd-for-netcgi2/nethttpd-for-netcgi2.cma /usr/lib64/ocaml/nethttpd-for-netcgi2/nethttpd_engine.cmi ok, I'll check this next week ;) hum... Koji fails on : ------------------------------------------------------------------------- Welcome to Ocamlnet version 2.2.8.1 Checking for findlib... found Checking multi-threading support... posix (ok) Checking for PCRE... found Checking operating system... Linux This OS supports passing credentials over Unix domain sockets Building rpc-auth-local Checking for POSIX shared memory... not found Checking switches for tcl.h... not ok Please check -equeue-tcl-defs! error: Bad exit status from /var/tmp/rpm-tmp.82618 (%prep) ----------------------------------------------------------------- it's seem that some BR are missing ping ? Sorry, been on holiday. I'll get back to this in a few days. This should fix it! Spec: http://www.annexia.org/tmp/ocaml/ocaml-ocamlnet.spec SRPM: http://www.annexia.org/tmp/ocaml/ocaml-ocamlnet-2.2.9-1.fc8.src.rpm +* Wed Nov 7 2007 Richard W.M. Jones <rjones> - 2.2.9-1 +- New upstream release 2.2.9. +- A more bletcherous, but more working, patch to fix the camlp4 + missing path bug. Hopefully this is very temporary. +- Added missing BR tcl-devel which was stopping mock from working. Hello Richard, i'll check it and other one. I was a bit busy at work these last times. Okay, Everythings sound good. + Missing BR have been included. + Missing Path have been included. ========== *APPROVED* ========== You can now request your CVSsync. New Package CVS Request ======================= Package Name: ocaml-ocamlnet Short Description: Network protocols for OCaml Owners: rjones,gemi Branches: F-8 InitialCC: rjones Cvsextras Commits: yes cvs done. |