Bug 241487 - Review Request: cduce - An XML-oriented functional language (ocaml)
Summary: Review Request: cduce - An XML-oriented functional language (ocaml)
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Xavier Lamien
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 240557 241472 241475 241476 241483 241486
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-05-26 15:37 UTC by Richard W.M. Jones
Modified: 2008-03-28 19:08 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-03-28 19:08:00 UTC
Type: ---
lxtnow: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Richard W.M. Jones 2007-05-26 15:37:48 UTC
Spec URL: http://annexia.org/tmp/cduce.spec
SRPM URL: http://annexia.org/tmp/cduce-0.4.2-1.src.rpm
Description: CDuce is an XML-oriented functional language.  http://cduce.org/

Comment 1 Jason Tibbitts 2007-06-02 05:58:52 UTC
Seems this has a dependency on ocaml-ocamlnet-devel which isn't in the distro
yet.  In fact, it hasn't been reviewed yet.  I'll add a dependency.

Comment 2 Xavier Lamien 2007-06-08 03:45:21 UTC
i'll start a full review once the bug dependency #241472 review will done (by me).


Comment 3 Xavier Lamien 2007-06-10 00:02:31 UTC
Added other bug dependencies blocks

Comment 4 Richard W.M. Jones 2007-06-11 19:56:26 UTC
Upstream CDuce haven't released a version which works with OCaml 3.10 yet.

Comment 5 Richard W.M. Jones 2007-08-06 11:05:21 UTC
Add magic word ocaml to summary.

Comment 6 Giuseppe Castagna 2007-09-12 08:54:39 UTC
Any news about it? The CDuce team has released a version compatible with OCaml
3.10 three months ago


Comment 7 Richard W.M. Jones 2007-09-12 09:43:25 UTC
I'll take a look, but it is an issue of spare time at the moment.

Comment 8 Richard W.M. Jones 2007-09-13 16:55:51 UTC
Spec URL: http://annexia.org/tmp/ocaml/cduce.spec
SRPM URL: http://annexia.org/tmp/ocaml/cduce-0.5.0-1.src.rpm

* Thu Sep 13 2007 Richard W.M. Jones <rjones> - 0.5.0-1
- Upstream version 0.5.0
- Remove RPATH in cduce binary.
- ExcludeArch ppc64.
- Build without ocamlopt.
- Convert AUTHORS file to UTF-8.
- Ignore Parsetree module.

Comment 9 Xavier Lamien 2007-09-21 16:02:03 UTC
ok, 
I'll check this next week ;)

Comment 10 Giuseppe Castagna 2007-12-01 16:06:22 UTC
I tried it on a fresh Fedora 8 install plus 

ocaml-ocamlnet-2.2.9-1.fc8.i386.rpm
ocaml-ocamlnet-devel-2.2.9-1.fc8.i386.rpm
ocaml-pxp-1.2.0test1-2.fc8.i386.rpm
ocaml-pxp-devel-1.2.0test1-2.fc8.i386.rpm

It works like a charm. 
The only think I do not understand is why you renamed the ocaml cgi package to
netcgi1. This for instance makes it impossible to compile cduce from svn without
appying first the patch.

In any case thanks a lot for the great work. Looking forward to see this
package approved

Comment 11 Richard W.M. Jones 2008-02-12 12:42:45 UTC
I've just rechecked and this still builds.  Any news?

Comment 12 Giuseppe Castagna 2008-02-15 11:32:03 UTC
A new 0.5.1 version of CDuce has been released.
http://www.cduce.org/download.html

Comment 13 Richard W.M. Jones 2008-02-15 19:33:16 UTC
Without the netcgi1 patch I can't get cduce to compile:

Checking for package camlp4... ok
Checking for package num... ok
Checking for package pcre... ok
Checking for package ulex... ok
Checking for package cgi... ocamlfind: Package `cgi' not found
failed !
*** Fatal error: Required package is not available
error: Bad exit status from /var/tmp/rpm-tmp.44682 (%prep)


Comment 14 Richard W.M. Jones 2008-02-15 19:44:53 UTC
Spec URL: http://annexia.org/tmp/ocaml/cduce.spec
SRPM URL: http://annexia.org/tmp/ocaml/cduce-0.5.1-1.fc9.src.rpm

* Fri Feb 15 2008 Richard W.M. Jones <rjones> - 0.5.1-1
- New upstream release 0.5.1.
- New OCaml 3.10.1.


Comment 15 Giuseppe Castagna 2008-02-17 11:23:27 UTC
(In reply to comment #13)
> Without the netcgi1 patch I can't get cduce to compile:
> 
> Checking for package camlp4... ok
> Checking for package num... ok
> Checking for package pcre... ok
> Checking for package ulex... ok
> Checking for package cgi... ocamlfind: Package `cgi' not found
> failed !

Ok, we fixed it in the svn version. Now if cgi package is not found
then cduce is build but dtd2cduce and and the web interface interpreter
are not. Thanks for the bug report.

Comment 16 Giuseppe Castagna 2008-02-17 11:31:35 UTC
(In reply to comment #14)
> Spec URL: http://annexia.org/tmp/ocaml/cduce.spec
>


In cduce.spec the following lines 

mv AUTHORS AUTHORS.old
iconv -f ISO-8859-1 -t UTF-8 < AUTHORS.old > AUTHORS

are no longer useful since now the AUTHORS file is in UTF-8


Comment 17 Giuseppe Castagna 2008-02-18 00:44:45 UTC
(In reply to comment #15)
> (In reply to comment #13)
> > Without the netcgi1 patch I can't get cduce to compile:
> > 
> > Checking for package camlp4... ok
> > Checking for package num... ok
> > Checking for package pcre... ok
> > Checking for package ulex... ok
> > Checking for package cgi... ocamlfind: Package `cgi' not found
> > failed !
> 
> Ok, we fixed it in the svn version. Now if cgi package is not found
> then cduce is build but dtd2cduce and and the web interface interpreter
> are not. Thanks for the bug report.

It now uses the netcgi1 package provided by ocaml-ocamlnet-xxx.rpm


Comment 18 Richard W.M. Jones 2008-02-23 23:29:39 UTC
Any idea when a new upstream official release might be out?

When one comes along I'll produce a new Fedora package for review.

Comment 19 Giuseppe Castagna 2008-02-25 19:54:23 UTC
(In reply to comment #18)
> Any idea when a new upstream official release might be out?
> 

Yes: today :-)

http://www.cduce.org/download.html


Comment 20 Richard W.M. Jones 2008-02-26 12:52:45 UTC
Is there a packaging problem with cduce 0.5.2?  It seems like the
file dtd2cduce.ml is missing, so when I build it I get this error:

Pack cduce_lib.cmo
Build cduce_lib.cma
make[1]: Leaving directory `/home/rjones/rpmbuild/BUILD/cduce-0.5.2'
make: *** No rule to make target `tools/dtd2cduce.ml', needed by `dtd2cduce'.  Stop.
error: Bad exit status from /var/tmp/rpm-tmp.31858 (%build)

Below is a diff of the manifests for 0.5.1 and 0.5.2:

@@ -51,6 +51,8 @@
 ./LICENSE
 ./Makefile
 ./Makefile.conf.template
+./Makefile.macosx
+./make-package-macosx
 ./META.in
 ./misc/bool.ml
 ./misc/bool.mli
@@ -146,10 +148,6 @@
 ./schema/schema_xml.ml
 ./schema/schema_xml.mli
 ./schema/TODO
-./tools/.cvsignore
-./tools/dtd2cduce.ml
-./tools/pull.ml
-./tools/validate.ml
 ./types/atoms.ml
 ./types/atoms.mli
 ./types/boolean.ml


Comment 21 Richard W.M. Jones 2008-02-26 22:47:39 UTC
Here's a new release based on 0.5.2-1.  Please don't use '-' character in
upstream release numbers!  It makes it hard to package!

Anyway:

Spec URL: http://www.annexia.org/tmp/ocaml/cduce.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/cduce-0.5.2.1-1.fc9.src.rpm

  * Tue Feb 26 2008 Richard W.M. Jones <rjones> - 0.5.2.1-1
  - New upstream release 0.5.2-1.

Here are the rpmlint errors:

  $ rpmlint /home/rjones/rpmbuild/SRPMS/cduce-0.5.2.1-1.fc9.src.rpm
  cduce.src:63: E: configure-without-libdir-spec

This is a problem in rpmlint.  See bug 433783.

  $ rpmlint /home/rjones/rpmbuild/RPMS/i386/cduce-0.5.2.1-1.fc9.i386.rpm
  cduce.i386: E: only-non-binary-in-usr-lib
  cduce.i386: W: ocaml-naming-policy-not-applied /usr/lib/ocaml/cduce/cduce_lib.cmi

See also bug 433783.

  $ rpmlint /home/rjones/rpmbuild/RPMS/i386/cduce-devel-0.5.2.1-1.fc9.i386.rpm
  cduce-devel.i386: W: ocaml-naming-policy-not-applied /usr/lib/ocaml/cduce/cduce_lib.a

As above.

Comment 22 Xavier Lamien 2008-03-01 18:05:10 UTC
just approved lastest require of ocaml-cduce.
Will finalize this one once you will import and build ocaml-pxp as well.

Comment 23 Richard W.M. Jones 2008-03-02 11:09:44 UTC
ocaml-pxp is built now.

Comment 24 Richard W.M. Jones 2008-03-10 21:38:57 UTC
Hello Xavier, any news on this?  We should be able to approve it now?

Comment 25 Xavier Lamien 2008-03-25 12:45:34 UTC
yep it is, sorry for the delay.

Fails on missing libs :
--> http://koji.fedoraproject.org/koji/getfile?taskID=529687&name=build.log






Comment 26 Richard W.M. Jones 2008-03-25 16:15:12 UTC
Ugh, missing BR.  Fixed and test built in Koji here:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=530193

Spec URL: http://www.annexia.org/tmp/ocaml/cduce.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/cduce-0.5.2.1-4.fc9.src.rpm

* Tue Mar 25 2008 Richard W.M. Jones <rjones> - 0.5.2.1-4
- ExcludeArch ppc64 again (see bug 438843).

* Tue Mar 25 2008 Richard W.M. Jones <rjones> - 0.5.2.1-3
- Added BR pcre-devel.
- Test build in Koji.

* Wed Mar  5 2008 Richard W.M. Jones <rjones> - 0.5.2.1-2
- Remove ExcludeArch ppc64.

Comment 27 Xavier Lamien 2008-03-27 13:26:54 UTC
test pass.

This package is ** Approved **.

Comment 28 Richard W.M. Jones 2008-03-28 09:18:00 UTC
New Package CVS Request
=======================
Package Name: cduce
Short Description: CDuce is a modern XML-oriented functional language
Owners: rjones
Branches: F-8
InitialCC: rjones
Cvsextras Commits: yes

Comment 29 Giuseppe Castagna 2008-03-28 10:06:33 UTC
Great!

Comment 30 Kevin Fenzi 2008-03-28 17:01:23 UTC
cvs done.

Comment 31 Richard W.M. Jones 2008-03-28 19:08:00 UTC
Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=536542

Fails in F-8 at the moment because ocaml-pxp hasn't yet migrated
out to the main repository, but I don't anticipate any problems.


Note You need to log in before you can comment on or make changes to this bug.