Bug 2416625

Summary:	Review Request: gtk-session-lock - Library to use GTK 3 to build screen lockers
Product:	[Fedora] Fedora	Reporter:	Joshua Strobl <joshua>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	RELEASE_PENDING ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://github.com/Cu3PO42/gtk-session-lock
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2416626

Description Joshua Strobl 2025-11-23 14:38:05 UTC

Spec URL: https://forge.moderndesktop.dev/JoshStrobl/fedora-package-reviews/raw/branch/main/gtk-session-lock/gtk-session-lock.spec
SRPM URL: https://forge.moderndesktop.dev/JoshStrobl/fedora-package-reviews/raw/branch/main/gtk-session-lock/gtk-session-lock-0.2.0-1.fc44.src.rpm
Description: gtk-session-lock is a library that enables the use of GTK3 to build Wayland screen lockers for compositors that support the ext-session-lock-v1 protocol. This is used particularly for gtklock (a GTK lock screen) that will be a runtime dependency for Fedora Budgie 44 (Budgie 10.10)
Fedora Account System Username: joshstrobl

Comment 1 Fedora Review Service 2025-11-23 14:42:48 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9830504
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416625-gtk-session-lock/fedora-rawhide-x86_64/09830504-gtk-session-lock/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2025-11-23 14:44:33 UTC

Initial spec review:

> Source: %{url}/archive/refs/tags/v%{version}.tar.gz

This should be "Source: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz"

Can you please fix this?

Comment 3 Neal Gompa 2025-11-23 14:44:52 UTC

Also, it needs "BuildRequires: gcc"

Comment 4 Joshua Strobl 2025-11-23 14:54:30 UTC

Should be fixed now :)

Comment 5 Neal Gompa 2025-11-23 15:19:15 UTC

Review notes:

* Package follows Fedora packaging guidelines
* Package builds and installs
* Package licensing is correct and license data is installed
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 6 Fedora Admin user for bugzilla script actions 2025-11-23 15:24:34 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/gtk-session-lock