Spec URL: https://forge.moderndesktop.dev/JoshStrobl/fedora-package-reviews/raw/branch/main/gtk-session-lock/gtk-session-lock.spec SRPM URL: https://forge.moderndesktop.dev/JoshStrobl/fedora-package-reviews/raw/branch/main/gtk-session-lock/gtk-session-lock-0.2.0-1.fc44.src.rpm Description: gtk-session-lock is a library that enables the use of GTK3 to build Wayland screen lockers for compositors that support the ext-session-lock-v1 protocol. This is used particularly for gtklock (a GTK lock screen) that will be a runtime dependency for Fedora Budgie 44 (Budgie 10.10) Fedora Account System Username: joshstrobl
Copr build: https://copr.fedorainfracloud.org/coprs/build/9830504 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416625-gtk-session-lock/fedora-rawhide-x86_64/09830504-gtk-session-lock/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Initial spec review: > Source: %{url}/archive/refs/tags/v%{version}.tar.gz This should be "Source: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz" Can you please fix this?
Also, it needs "BuildRequires: gcc"
Should be fixed now :)
Review notes: * Package follows Fedora packaging guidelines * Package builds and installs * Package licensing is correct and license data is installed * No serious issues from rpmlint PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/gtk-session-lock