Bug 2416626

Summary:	Review Request: gtklock - Lock screen based on gtkgreet
Product:	[Fedora] Fedora	Reporter:	Joshua Strobl <joshua>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	RELEASE_PENDING ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://github.com/jovanlanik/gtklock
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2416625
Bug Blocks:

Description Joshua Strobl 2025-11-23 14:39:40 UTC

Spec URL: https://forge.moderndesktop.dev/JoshStrobl/fedora-package-reviews/raw/branch/main/gtklock/gtklock.spec
SRPM URL: https://forge.moderndesktop.dev/JoshStrobl/fedora-package-reviews/raw/branch/main/gtklock/gtklock-4.0.0-1.fc44.src.rpm
Description: gtklock is a lock screen based on gtkgreet, using ext-session-lock Wayland protocol. This will be used in Fedora Budgie 44 (Budgie 10.10).
Fedora Account System Username: joshstrobl

Comment 1 Fedora Review Service 2025-11-23 14:41:36 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9830505
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416626-gtklock/fedora-rawhide-x86_64/09830505-gtklock/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2025-11-23 14:46:17 UTC

Initial spec review:

> Source: %{url}/archive/refs/tags/v%{version}.tar.gz

This should be "Source: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz"

> %{_mandir}/man1/%{name}.1.gz

This should be "%{_mandir}/man1/%{name}.1*"

Can you please fix these?

Comment 3 Joshua Strobl 2025-11-23 14:54:47 UTC

Should be fixed now :)

Comment 4 Neal Gompa 2025-11-23 15:18:54 UTC

Review notes:

* Package follows Fedora packaging guidelines
* Package builds and installs
* Package licensing is correct and license data is installed
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2025-11-23 15:25:16 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/gtklock