Bug 2416645
| Summary: | Review Request: budgie-display-configurator - Graphical display configuration tool for Budgie Desktop | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Joshua Strobl <joshua> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | RELEASE_PENDING --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://forge.moderndesktop.dev/BuddiesOfBudgie/budgie-display-configurator | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2416646 | ||
| Bug Blocks: | |||
|
Description
Joshua Strobl
2025-11-23 18:48:07 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9830763 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416645-budgie-display-configurator/fedora-rawhide-x86_64/09830763-budgie-display-configurator/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec review: > Source0: %{url}/archive/%{version}.tar.gz This should be "Source0: %{url}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz" Also, no license files are installed. Can you please install them with "%license"? Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Should be fixed now :) Review notes: * Package follows Fedora packaging guidelines * Package builds and installs * Package licensing is correct and license data is installed * No serious issues from rpmlint PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/budgie-display-configurator |