Spec URL: https://forge.moderndesktop.dev/JoshStrobl/fedora-package-reviews/raw/branch/main/budgie-display-configurator/budgie-display-configurator.spec SRPM URL: https://forge.moderndesktop.dev/JoshStrobl/fedora-package-reviews/raw/branch/main/budgie-display-configurator/budgie-display-configurator-0.0.1-1.fc44.src.rpm Description: Graphical display configuration tool for Budgie Desktop Fedora Account System Username: joshstrobl
Copr build: https://copr.fedorainfracloud.org/coprs/build/9830763 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416645-budgie-display-configurator/fedora-rawhide-x86_64/09830763-budgie-display-configurator/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec review: > Source0: %{url}/archive/%{version}.tar.gz This should be "Source0: %{url}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz" Also, no license files are installed. Can you please install them with "%license"? Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text
Should be fixed now :)
Review notes: * Package follows Fedora packaging guidelines * Package builds and installs * Package licensing is correct and license data is installed * No serious issues from rpmlint PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/budgie-display-configurator