Bug 2416646

Summary: Review Request: budgie-desktop-services - Daemon responsible for enabling various features of Budgie Desktop
Product: [Fedora] Fedora Reporter: Joshua Strobl <joshua>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: RELEASE_PENDING --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://forge.moderndesktop.dev/BuddiesOfBudgie/budgie-desktop-services
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2416645    

Comment 1 Fedora Review Service 2025-11-23 18:58:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9830764
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416646-budgie-desktop-services/fedora-rawhide-x86_64/09830764-budgie-desktop-services/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2025-11-23 19:06:30 UTC
Spec review:

> Source0: %{url}/archive/%{version}.tar.gz

This should be "Source0: %{url}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz"

Also, no license files are installed. Can you please install them with "%license"?

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Comment 3 Joshua Strobl 2025-11-23 19:22:25 UTC
Should be fixed now :)

Comment 4 Neal Gompa 2025-11-23 19:26:49 UTC
Review notes:

* Package follows Fedora packaging guidelines
* Package builds and installs
* Package licensing is correct and license data is installed
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2025-11-23 19:27:34 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/budgie-desktop-services