Bug 2416695
| Summary: | Review Request: rust-serde_assert - Testing library for serde Serialize and Deserialize implementations | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rodolfo Olivieri <rodolfo.olivieri3> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, fedora, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/serde_assert | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-02-18 14:12:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Rodolfo Olivieri
2025-11-24 00:50:22 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9831166 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416695-rust-serde_assert/fedora-rawhide-x86_64/09831166-rust-serde_assert/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. It looks like packit mangled this spec file into a form that is not in line with the (Rust) packaging guidelines. Please submit the original spec file for review. Additionally, please add a comment that explains the Patch you added, and ideally, also a link to an upstream issue / pull request / commit. The published crates also seem to include files with CRLF / Windows-style line endings. I would recommend to report this upstream (since it's usually unintentional) and for now, fix it in packaging with dos2unix or sed. Hi, Fabio! Sure. I think the builds expired. I will retake this work in a couple of days, still finishing other priority work first. Thanks for the feedback. Hi, Fabio! Here's an up-to-date version of the specfile/srpm build: Spec URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-serde_assert/fedora-rawhide-x86_64/10034808-rust-serde_assert/rust-serde_assert.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-serde_assert/fedora-rawhide-x86_64/10034800-rust-serde_assert/rust-serde_assert-0.8.0-1.fc44.src.rpm I don't know why I had that patch in the previous one, but it's gone now. Created attachment 2122780 [details]
The .spec file difference from Copr build 9831166 to 10035992
Copr build: https://copr.fedorainfracloud.org/coprs/build/10035992 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416695-rust-serde_assert/fedora-rawhide-x86_64/10035992-rust-serde_assert/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > I don't know why I had that patch in the previous one, but it's gone now. Well, you replaced it with this: > # Relax dependency for claims crate > tomcli set Cargo.toml str dev-dependencies.claims ">=0.7.1,0.9.0" Which breaks builds of the package, because it has a typo (should be ">=0.7.1,<0.9.0" - note the "<"). That said, changes to Cargo.toml MUST be made with "rust2rpm -p", otherwise the package might be broken. The contents of Cargo.toml affect the generated spec file, so the final Cargo.toml contents must be known *before* generating the .spec file (which is only the case when using "rust2rpm -p"). Spec URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-serde_assert/fedora-rawhide-x86_64/10047398-rust-serde_assert/rust-serde_assert.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-serde_assert/fedora-rawhide-x86_64/10047398-rust-serde_assert/rust-serde_assert-0.8.0-1.fc44.src.rpm Updated 🫡! Created attachment 2123252 [details]
The .spec file difference from Copr build 10035992 to 10047401
Copr build: https://copr.fedorainfracloud.org/coprs/build/10047401 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416695-rust-serde_assert/fedora-rawhide-x86_64/10047401-rust-serde_assert/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. (In reply to Rodolfo Olivieri from comment #8) > Spec URL: > https://download.copr.fedorainfracloud.org/results/r0x0d/rust-serde_assert/ > fedora-rawhide-x86_64/10047398-rust-serde_assert/rust-serde_assert.spec > SRPM URL: > https://download.copr.fedorainfracloud.org/results/r0x0d/rust-serde_assert/ > fedora-rawhide-x86_64/10047398-rust-serde_assert/rust-serde_assert-0.8.0-1. > fc44.src.rpm > > Updated 🫡! Please upload again, the links have already expired. Spec URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-serde_assert/fedora-rawhide-x86_64/10109910-rust-serde_assert/rust-serde_assert.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-serde_assert/fedora-rawhide-x86_64/10109910-rust-serde_assert/rust-serde_assert-0.8.0-1.fc45.src.rpm Created attachment 2128806 [details]
The .spec file difference from Copr build 10047401 to 10109912
Copr build: https://copr.fedorainfracloud.org/coprs/build/10109912 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416695-rust-serde_assert/fedora-rawhide-x86_64/10109912-rust-serde_assert/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thanks! Package looks good to me, with one minor issue: ./.cargo_vcs_info.json: JSON text data ./.github/dependabot.yml: ASCII text, with CRLF line terminators ./.github/workflows/test.yaml: ASCII text, with CRLF line terminators ./.gitignore: ASCII text, with CRLF line terminators ./CHANGELOG.md: ASCII text, with CRLF line terminators ./Cargo.toml: ASCII text ./Cargo.toml.orig: ASCII text, with CRLF line terminators ./LICENSE-APACHE: ASCII text, with CRLF line terminators ./LICENSE-MIT: ASCII text, with CRLF line terminators ./README.md: ASCII text, with very long lines (638), with CRLF line terminators ./rustfmt.toml: ASCII text, with CRLF line terminators ./src/de.rs: ASCII text, with CRLF line terminators ./src/lib.rs: C source, ASCII text, with CRLF line terminators ./src/ser.rs: ASCII text ./src/token.rs: ASCII text, with CRLF line terminators ./tests/roundtrip.rs: ASCII text, with CRLF line terminators It looks like most files have CRLF line endings. You might want to fix this downstream (BuildRequires: dos2unix, running dos2unix --keepdate $path for all affected files), and file an issue with the upstream project. It looks like they might have published the crate from a Windows (?) system where git is misconfigured. SPEC URL: https://r0x0d.fedorapeople.org/rust-serde_assert/rust-serde_assert.spec SRPM URL: https://r0x0d.fedorapeople.org/rust-serde_assert/rust-serde_assert-0.8.0-1.fc45.src.rpm rust2rpm URL: https://r0x0d.fedorapeople.org/rust-serde_assert/rust2rpm.toml Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=142257688 Looks like this is ~equivalent to the previous submission, and the CRLF line ending issue is not addressed? Ah, sorry! Got fooled by running rust2rpm and missing the [scripts] and [requires] table. Updating again. SPEC URL: https://r0x0d.fedorapeople.org/rust-serde_assert/rust-serde_assert.spec SRPM URL: https://r0x0d.fedorapeople.org/rust-serde_assert/rust-serde_assert-0.8.0-1.fc45.src.rpm rust2rpm URL: https://r0x0d.fedorapeople.org/rust-serde_assert/rust2rpm.toml Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=142261129 > # Find all files that have CRLF line endings (Windows)
> find . -type f -exec dos2unix -ic {} +
Well this does *find* them, but it doesn't ... *fix* them.
I would do something like this instead:
find . -type f -exec dos2unix --keepdate '{}' '+'
SPEC URL: https://r0x0d.fedorapeople.org/rust-serde_assert/rust-serde_assert.spec SRPM URL: https://r0x0d.fedorapeople.org/rust-serde_assert/rust-serde_assert-0.8.0-1.fc45.src.rpm rust2rpm URL: https://r0x0d.fedorapeople.org/rust-serde_assert/rust2rpm.toml Updated once more, now included the `--keepdate` parameter. Sorry for missing it out. Looks good now, thank you! === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-serde_assert FEDORA-2026-31565ff139 (rust-serde_assert-0.8.0-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-31565ff139 FEDORA-2026-31565ff139 (rust-serde_assert-0.8.0-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report. *** Bug 2336533 has been marked as a duplicate of this bug. *** |