Bug 2336533 - Review Request: rust-serde_assert - Testing library for serde Serialize and Deserialize implementations
Summary: Review Request: rust-serde_assert - Testing library for serde Serialize and D...
Keywords:
Status: POST
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/serde_assert
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-01-09 11:35 UTC by Kai A. Hiller
Modified: 2025-04-01 10:06 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Kai A. Hiller 2025-01-09 11:35:44 UTC
Spec URL: https://v02460.fedorapeople.org/rust-serde_assert.spec
SRPM URL: https://v02460.fedorapeople.org/rust-serde_assert-0.8.0-1.fc42.src.rpm
Description: Testing library for serde Serialize and Deserialize implementations.
Fedora Account System Username: v02460

Comment 1 Fedora Review Service 2025-01-09 11:41:10 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8493102
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2336533-rust-serde_assert/fedora-rawhide-x86_64/08493102-rust-serde_assert/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2025-03-14 17:13:53 UTC
Package looks good to me!

Can you add a link to the corresponding upstream commit that bumps the "claims" dependency as a comment to the spec file?
https://github.com/Anders429/serde_assert/commit/f5ee1b6

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fabio Valentini 2025-03-29 22:32:09 UTC
Are you still interested in this package?

If you need to import it, let me know, I will likely need to refresh the fedora-review + flag on this bug.

Comment 4 Kai A. Hiller 2025-03-31 23:30:53 UTC
Thanks, I’d be glad if you could renew the approval

Comment 5 Fabio Valentini 2025-04-01 10:06:39 UTC
done!


Note You need to log in before you can comment on or make changes to this bug.