Bug 2418265

Summary:	Review Request: perl-Chemistry-Ring - Represent a ring as a substructure of a molecule
Product:	[Fedora] Fedora	Reporter:	Dominik 'Rathann' Mierzejewski <dominik>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	ASSIGNED ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://metacpan.org/dist/Chemistry-Ring
Whiteboard:	Trivial
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2417375, 2417808
Bug Blocks:	2417812, 2418262, 2418263, 2418592

Description Dominik 'Rathann' Mierzejewski 2025-12-02 08:48:08 UTC

Spec URL: https://rathann.fedorapeople.org/review/perl-Chemistry-Pattern/perl-Chemistry-Ring.spec
SRPM URL: https://rathann.fedorapeople.org/review/perl-Chemistry-Ring/perl-Chemistry-Ring-0.21-1.fc44.src.rpm
Description:
This module provides some basic methods for representing a ring. A ring is a
subclass of molecule, because it has atoms and bonds. Besides that, it has some
useful geometric methods for finding the centroid and the ring plane, and
methods for aromaticity detection.

This module does not detect the rings by itself; for that, look at
Chemistry::Ring::Find.

This module is part of the PerlMol project.

Fedora Account System Username: rathann

Comment 1 Fedora Review Service 2025-12-03 04:42:45 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9859413
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2418265-perl-chemistry-ring/fedora-rawhide-x86_64/09859413-perl-Chemistry-Ring/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Jitka Plesnikova 2026-01-27 11:27:22 UTC

Fixed spec URL

Spec URL: https://rathann.fedorapeople.org/review/perl-Chemistry-Ring/perl-Chemistry-Ring.spec
SRPM URL: https://rathann.fedorapeople.org/review/perl-Chemistry-Ring/perl-Chemistry-Ring-0.21-1.fc44.src.rpm

Comment 3 Petr Pisar 2026-04-21 07:20:54 UTC

URL and Souce0 are usable. Ok.
Source0 archive (SHA512: ee85147ac0c3095a26c7c70cf65d4b7d099d49f6914f3cd8d05d963bdeda68ea90595cd6e5b586b06e9dfef77ae82a863caf573c74f244f7477e78fde3a4dbc1) is original. Ok.
Summary verified from lib/Chemistry/Ring.pm. Ok.
Description verified from lib/Chemistry/Ring.pm. Ok.
No XS code, noarch BuildArch is Ok.
License verified from lib/Chemistry/Ring/Find.pm, lib/Chemistry/Ring.pm, Makefile.PL, README, dist.ini. Ok.

TODO: Build-require "coreutils" for %{_fixperms} macro (perl-Chemistry-Ring.spec:46).
TODO: Constrain "perl(Chemistry::Mol)" dependency with ">= 0.24" (META.json:24).
TODO: Constrain "perl(Statistics::Regression)" dependency with ">= 0.15" (META.json:25).

FIX: Build-require "perl(strict)" (Makefile.PL:2).
FIX: Build-require "perl(warnings)" (Makefile.PL:3).
FIX: Build-require "perl(base)" (lib/Chemistry/Ring.pm:53).
FIX: Build-require "perl(Exporter)" (lib/Chemistry/Ring.pm:53).
FIX: Build-require "perl(Scalar::Util)" (lib/Chemistry/Ring.pm:54).

FIX: Remove the "find %{buildroot} -type f -name '*.bs' -empty -delete" line at perl-Chemistry-Ring.spec:45. It's not needed for noarch Perl packages.

FIX: Package "Changes" file as a documenation.

FATAL: This package build-require "perl(Chemistry::File::SMILES)" which is not provided by any package in Fedora. Please package that first.

Comment 4 Petr Pisar 2026-04-21 07:24:01 UTC

You have build-cycle with perl-Chemistry-File-SMILES (bug #2417812). You need to find out which of the two packages needs the other less and conditionalize that dependency with %{defined perl_bootstrap} and temporarily disable that dependency until both packages are in Fedora.