Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://rathann.fedorapeople.org/review/perl-Chemistry-Pattern/perl-Chemistry-Ring.spec SRPM URL: https://rathann.fedorapeople.org/review/perl-Chemistry-Ring/perl-Chemistry-Ring-0.21-1.fc44.src.rpm Description: This module provides some basic methods for representing a ring. A ring is a subclass of molecule, because it has atoms and bonds. Besides that, it has some useful geometric methods for finding the centroid and the ring plane, and methods for aromaticity detection. This module does not detect the rings by itself; for that, look at Chemistry::Ring::Find. This module is part of the PerlMol project. Fedora Account System Username: rathann
Copr build: https://copr.fedorainfracloud.org/coprs/build/9859413 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2418265-perl-chemistry-ring/fedora-rawhide-x86_64/09859413-perl-Chemistry-Ring/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Fixed spec URL Spec URL: https://rathann.fedorapeople.org/review/perl-Chemistry-Ring/perl-Chemistry-Ring.spec SRPM URL: https://rathann.fedorapeople.org/review/perl-Chemistry-Ring/perl-Chemistry-Ring-0.21-1.fc44.src.rpm
URL and Souce0 are usable. Ok. Source0 archive (SHA512: ee85147ac0c3095a26c7c70cf65d4b7d099d49f6914f3cd8d05d963bdeda68ea90595cd6e5b586b06e9dfef77ae82a863caf573c74f244f7477e78fde3a4dbc1) is original. Ok. Summary verified from lib/Chemistry/Ring.pm. Ok. Description verified from lib/Chemistry/Ring.pm. Ok. No XS code, noarch BuildArch is Ok. License verified from lib/Chemistry/Ring/Find.pm, lib/Chemistry/Ring.pm, Makefile.PL, README, dist.ini. Ok. TODO: Build-require "coreutils" for %{_fixperms} macro (perl-Chemistry-Ring.spec:46). TODO: Constrain "perl(Chemistry::Mol)" dependency with ">= 0.24" (META.json:24). TODO: Constrain "perl(Statistics::Regression)" dependency with ">= 0.15" (META.json:25). FIX: Build-require "perl(strict)" (Makefile.PL:2). FIX: Build-require "perl(warnings)" (Makefile.PL:3). FIX: Build-require "perl(base)" (lib/Chemistry/Ring.pm:53). FIX: Build-require "perl(Exporter)" (lib/Chemistry/Ring.pm:53). FIX: Build-require "perl(Scalar::Util)" (lib/Chemistry/Ring.pm:54). FIX: Remove the "find %{buildroot} -type f -name '*.bs' -empty -delete" line at perl-Chemistry-Ring.spec:45. It's not needed for noarch Perl packages. FIX: Package "Changes" file as a documenation. FATAL: This package build-require "perl(Chemistry::File::SMILES)" which is not provided by any package in Fedora. Please package that first.
You have build-cycle with perl-Chemistry-File-SMILES (bug #2417812). You need to find out which of the two packages needs the other less and conditionalize that dependency with %{defined perl_bootstrap} and temporarily disable that dependency until both packages are in Fedora.
(In reply to Petr Pisar from comment #3) > TODO: Build-require "coreutils" for %{_fixperms} macro > (perl-Chemistry-Ring.spec:46). > TODO: Constrain "perl(Chemistry::Mol)" dependency with ">= 0.24" > (META.json:24). > TODO: Constrain "perl(Statistics::Regression)" dependency with ">= 0.15" > (META.json:25). > > FIX: Build-require "perl(strict)" (Makefile.PL:2). > FIX: Build-require "perl(warnings)" (Makefile.PL:3). > FIX: Build-require "perl(base)" (lib/Chemistry/Ring.pm:53). > FIX: Build-require "perl(Exporter)" (lib/Chemistry/Ring.pm:53). > FIX: Build-require "perl(Scalar::Util)" (lib/Chemistry/Ring.pm:54). > > FIX: Remove the "find %{buildroot} -type f -name '*.bs' -empty -delete" line > at perl-Chemistry-Ring.spec:45. It's not needed for noarch Perl packages. > > FIX: Package "Changes" file as a documenation. All fixed, thanks for the review. > FATAL: This package build-require "perl(Chemistry::File::SMILES)" which is > not provided by any package in Fedora. Please package that first. Up for review under bug 2417812.
(In reply to Petr Pisar from comment #4) > You have build-cycle with perl-Chemistry-File-SMILES (bug #2417812). You > need to find out which of the two packages needs the other less and > conditionalize that dependency with %{defined perl_bootstrap} and > temporarily disable that dependency until both packages are in Fedora. It appears that SMILES is only used for some tests, so let's make it optional here to break the cycle: t/find_ring.t ... skipped: You don't have Chemistry::File::SMILES installed t/find_rings.t .. skipped: You don't have Chemistry::File::SMILES installed
Spec URL: https://rathann.fedorapeople.org/review/perl-Chemistry-Ring/perl-Chemistry-Ring.spec SRPM URL: https://rathann.fedorapeople.org/review/perl-Chemistry-Ring/perl-Chemistry-Ring-0.21-2.fc45.src.rpm * Tue Jun 09 2026 Dominik 'Rathann' Mierzejewski <dominik> - 0.21-2 - add missing dependencies and version constraints - include Changes file in documentation - break the dependency cycle with Chemistry::File::SMILES here
Copr build: https://copr.fedorainfracloud.org/coprs/build/10583840 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2418265-perl-chemistry-ring/fedora-rawhide-x86_64/10583840-perl-Chemistry-Ring/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Created attachment 2144877 [details] The .spec file difference from Copr build 10583840 to 10583871
Copr build: https://copr.fedorainfracloud.org/coprs/build/10583871 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2418265-perl-chemistry-ring/fedora-rawhide-x86_64/10583871-perl-Chemistry-Ring/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks for the update. TODO: Remove OPTIMIZE argument from perl Makefile.PL program. It's not needed for noarch packages. FIX: The perl_bootstrap macro is a Perl ecosystem-wide macro which enables building all Perl packages from scratch and it's supposed to be used differently. For an example look at <https://src.fedoraproject.org/rpms/perl-IO-Compress/raw/rawhide/f/perl-IO-Compress.spec>. Correct usage for your package is this: --- perl-Chemistry-Ring.spec 2026-06-09 18:43:03.000000000 +0200 +++ perl-Chemistry-Ring.spec.new 2026-06-10 09:13:22.423388993 +0200 @@ -1,5 +1,5 @@ %bcond check 1 -%bcond perl_bootstrap 1 +%define perl_bootstrap 1 Name: perl-Chemistry-Ring Version: 0.21 @@ -19,7 +19,7 @@ BuildRequires: perl(strict) BuildRequires: perl(warnings) %if %{with check} -%if %{without perl_bootstrap} +%if !%{defined perl_bootstrap} BuildRequires: perl(Chemistry::File::SMILES) %endif BuildRequires: perl(Chemistry::Mol) >= 0.24 After getting Chemistry::File::SMILES into Fedora, you delete the "%define perl_bootstrap 1" line from this spec file. That's all. All tests pass. Ok. $ rpmlint perl-Chemistry-Ring.spec ../SRPMS/perl-Chemistry-Ring-0.21-1.fc45.src.rpm ../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-Chemistry-Ring.noarch: E: spelling-error ('centroid', '%description -l en_US centroid -> centric') perl-Chemistry-Ring.noarch: E: spelling-error ('aromaticity', '%description -l en_US aromaticity -> aromatically, aromatic') perl-Chemistry-Ring.src: E: spelling-error ('centroid', '%description -l en_US centroid -> centric') perl-Chemistry-Ring.src: E: spelling-error ('aromaticity', '%description -l en_US aromaticity -> aromatically, aromatic') === 2 packages and 1 specfiles checked; 4 errors, 0 warnings, 6 filtered, 4 badness; has taken 0.5 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm drwxr-xr-x 2 root root 0 Jun 10 02:00 /usr/share/doc/perl-Chemistry-Ring -rw-r--r-- 1 root root 1252 Dec 16 2022 /usr/share/doc/perl-Chemistry-Ring/Changes -rw-r--r-- 1 root root 1359 Dec 16 2022 /usr/share/doc/perl-Chemistry-Ring/README -rw-r--r-- 1 root root 2313 Jun 10 02:00 /usr/share/man/man3/Chemistry::Ring.3pm.gz -rw-r--r-- 1 root root 2617 Jun 10 02:00 /usr/share/man/man3/Chemistry::Ring::Find.3pm.gz drwxr-xr-x 2 root root 0 Jun 10 02:00 /usr/share/perl5/vendor_perl/Chemistry drwxr-xr-x 2 root root 0 Jun 10 02:00 /usr/share/perl5/vendor_perl/Chemistry/Ring -rw-r--r-- 1 root root 6153 Dec 16 2022 /usr/share/perl5/vendor_perl/Chemistry/Ring.pm -rw-r--r-- 1 root root 10644 Dec 16 2022 /usr/share/perl5/vendor_perl/Chemistry/Ring/Find.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm | sort -f | uniq -c 1 perl(base) 1 perl(Chemistry::Mol) 1 perl(Chemistry::Ring) 1 perl(Math::VectorReal) 1 perl(Scalar::Util) 1 perl(Statistics::Regression) 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Constrain "perl(Chemistry::Mol)" run-time dependency with ">= 0.24" (META.json:24). TODO: Constrain "perl(Statistics::Regression)" run-time dependency with ">= 0.15" (META.json:25). FIX: Run-require "perl(Exporter)" (lib/Chemistry/Ring.pm:53). $ rpm -q --provides -p ../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm | sort -f | uniq -c 1 perl(Chemistry::Ring) = 0.21 1 perl(Chemistry::Ring::Find) = 0.21 1 perl-Chemistry-Ring = 0.21-1.fc45 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in F45 (https://koji.fedoraproject.org/koji/taskinfo?taskID=146468355). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX items, consider fixing the TODO items, and provide a new spec file.
Spec URL: https://rathann.fedorapeople.org/review/perl-Chemistry-Ring/perl-Chemistry-Ring.spec SRPM URL: https://rathann.fedorapeople.org/review/perl-Chemistry-Ring/perl-Chemistry-Ring-0.21-3.fc45.src.rpm - add missing runtime requirements and constraints - correct perl_bootstrap macro usage - drop unused OPTIMIZE option from perl Makefile.PL call Thanks!
$ rpmlint perl-Chemistry-Ring.spec ../SRPMS/perl-Chemistry-Ring-0.21-1.fc45.src.rpm ../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-Chemistry-Ring.noarch: E: spelling-error ('centroid', '%description -l en_US centroid -> centric') perl-Chemistry-Ring.noarch: E: spelling-error ('aromaticity', '%description -l en_US aromaticity -> aromatically, aromatic') perl-Chemistry-Ring.src: E: spelling-error ('centroid', '%description -l en_US centroid -> centric') perl-Chemistry-Ring.src: E: spelling-error ('aromaticity', '%description -l en_US aromaticity -> aromatically, aromatic') === 2 packages and 1 specfiles checked; 4 errors, 0 warnings, 6 filtered, 4 badness; has taken 0.5 s == rpmlint is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm | sort -f | uniq -c 1 perl(base) 1 perl(Chemistry::Mol) 1 perl(Chemistry::Mol) >= 0.24 1 perl(Chemistry::Ring) 1 perl(Exporter) 1 perl(Math::VectorReal) 1 perl(Scalar::Util) 1 perl(Statistics::Regression) 1 perl(Statistics::Regression) >= 0.15 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Remove the underspecified unversioned run-time dependencies on "perl(Chemistry::Mol)" and "perl(Statistics::Regression)" to minimize the set of dependencies. How to do is somewhat documented at <https://docs.fedoraproject.org/en-US/packaging-guidelines/AutoProvidesAndRequiresFiltering/>, but this example <https://src.fedoraproject.org/rpms/perl-PDF-Builder/blob/rawhide/f/perl-PDF-Builder.spec#_119> is probably easier to understand. $ resolvedeps rawhide ../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=146481756). Ok. This package is in line with Fedora and Perl packaging guidelines. Please consider fixing the TODO item before building this package. This package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Chemistry-Ring Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
FEDORA-2026-2ea070edd0 (perl-Chemistry-Ring-0.21-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-2ea070edd0
FEDORA-2026-2ea070edd0 (perl-Chemistry-Ring-0.21-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.