Bug 241893

Summary: /bin/unicode_stop missing argument for "test -t FD"
Product: [Fedora] Fedora Reporter: Thomas Steudten <tomri>
Component: kbdAssignee: Vitezslav Crhonek <vcrhonek>
Status: CLOSED NOTABUG QA Contact:
Severity: high Docs Contact:
Priority: low    
Version: 6   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-09-04 09:10:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 241896    

Description Thomas Steudten 2007-05-31 14:56:23 UTC 
kbd-1.12-18.src.rpm

/bin/unicode_stop:
#!/bin/sh
# stop unicode
kbd_mode -a
if test -t ; then
        echo -n -e '\033%@'
fi

See /bin/unicode_start for reference; Expression should be "test -t 1" at least,
to test for a terminal on stdout.
Comment 1 Vitezslav Crhonek 2007-06-06 14:24:54 UTC 
Hi,

thanks for reporting. I wonder if this test is actually needed in both
unicode_start and unicode_stop at all. I'll check it out.
Comment 2 Thomas Steudten 2007-08-30 18:35:30 UTC 
It this fixed?
Comment 3 Vitezslav Crhonek 2007-09-04 09:10:36 UTC 
Hi,

there's no fix necessary:

test -t fd -- true if fd is an open file descriptor associated with a terminal
(fd is 1 by default)

Closing as NOTABUG.