Bug 2419775
| Summary: | Review Request: rust-pbr - Console progress bar for Rust | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Robinson <pbrobinson> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/pbr | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2252384 | ||
|
Description
Peter Robinson
2025-12-07 19:00:52 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9883632 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2419775-rust-pbr/fedora-rawhide-x86_64/09883632-rust-pbr/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-pbr Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. It looks like there's only one test that fails without a TTY: "tty::unix::compare_with_stty". You should be able to enable tests and skip just that one test. ``` %cargo_test -- -- --skip tty::unix::compare_with_stty ``` should work. ``` [tests] skip = ["tty::unix::compare_with_stty"] comments = ["skip one tests that requires a TTY"] ``` would be the equivalent rust2rpm.toml config snippet. > %cargo_test -- -- --skip tty::unix::compare_with_stty That works. > ``` > [tests] > skip = ["tty::unix::compare_with_stty"] > comments = ["skip one tests that requires a TTY"] > ``` > > would be the equivalent rust2rpm.toml config snippet. How do we deal with that in a package review? The later is obviously more sustainable from the rust2rpm PoV. Do we just agree it's the correct solution and I commit is as part of the import? > Do we just agree it's the correct solution and I commit is as part of the import?
Usually yes, just import the rust2rpm settings file into dist-git alongside the .spec file.
|