SPEC: https://pbrobinson.fedorapeople.org/rust-pbr.spec SRPM: https://pbrobinson.fedorapeople.org/rust-pbr-1.1.1-1.fc43.src.rpm Description: Console progress bar for Rust FAS: pbrobinson koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=139801983 Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/9883632 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2419775-rust-pbr/fedora-rawhide-x86_64/09883632-rust-pbr/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-pbr Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
It looks like there's only one test that fails without a TTY: "tty::unix::compare_with_stty". You should be able to enable tests and skip just that one test. ``` %cargo_test -- -- --skip tty::unix::compare_with_stty ``` should work. ``` [tests] skip = ["tty::unix::compare_with_stty"] comments = ["skip one tests that requires a TTY"] ``` would be the equivalent rust2rpm.toml config snippet.
> %cargo_test -- -- --skip tty::unix::compare_with_stty That works. > ``` > [tests] > skip = ["tty::unix::compare_with_stty"] > comments = ["skip one tests that requires a TTY"] > ``` > > would be the equivalent rust2rpm.toml config snippet. How do we deal with that in a package review? The later is obviously more sustainable from the rust2rpm PoV. Do we just agree it's the correct solution and I commit is as part of the import?
> Do we just agree it's the correct solution and I commit is as part of the import? Usually yes, just import the rust2rpm settings file into dist-git alongside the .spec file.