Bug 2422923
| Summary: | Review Request: rust-diskus - Minimal, fast alternative to 'du -sh' | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> | ||||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://crates.io/crates/diskus | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | --- | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2025-12-16 23:23:24 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 2422900 | ||||||||
| Attachments: |
|
||||||||
|
Description
Ben Beasley
2025-12-16 20:47:52 UTC
Created attachment 2118971 [details]
Updated configuration file for rust2rpm
Corrected a minor error in a patch comment and re-uploaded the spec and SRPM.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9915946 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2422923-rust-diskus/fedora-rawhide-x86_64/09915946-rust-diskus/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/9915947 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2422923-rust-diskus/fedora-rawhide-x86_64/09915947-rust-diskus/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package looks good to me, only one minor thing: The project appears to ship its own man page (doc/diskus.1) - why are you building one with help2man instead? (In reply to Fabio Valentini from comment #4) > Package looks good to me, only one minor thing: > > The project appears to ship its own man page (doc/diskus.1) - why are you > building one with help2man instead? Only because I forgot to look closely enough at the source tree. Thank you for catching that. Let me fix it. Great. I trust that you'll fix that - and since it was the only issue I can see ... === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ patches are documented and reasonable ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ licenses of statically linked dependencies are correctly taken into account ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-diskus FEDORA-2025-726ece9813 (rust-diskus-0.9.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-726ece9813 FEDORA-2025-726ece9813 (rust-diskus-0.9.0-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-1396f1dd8e (rust-diskus-0.9.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-1396f1dd8e FEDORA-2025-7ef7af83f0 (rust-diskus-0.9.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-7ef7af83f0 FEDORA-EPEL-2025-b25b36281f (rust-diskus-0.9.0-1.el10_2) has been submitted as an update to Fedora EPEL 10.2. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-b25b36281f FEDORA-EPEL-2025-6ad12a8dfc (rust-diskus-0.9.0-1.el10_1) has been submitted as an update to Fedora EPEL 10.1. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-6ad12a8dfc FEDORA-EPEL-2025-37b0f6eb51 (rust-diskus-0.9.0-1.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-37b0f6eb51 FEDORA-EPEL-2025-b25b36281f has been pushed to the Fedora EPEL 10.2 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-b25b36281f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-1396f1dd8e has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-1396f1dd8e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-1396f1dd8e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2025-6ad12a8dfc has been pushed to the Fedora EPEL 10.1 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-6ad12a8dfc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2025-37b0f6eb51 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-37b0f6eb51 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-7ef7af83f0 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-7ef7af83f0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-7ef7af83f0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-1396f1dd8e (rust-diskus-0.9.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-7ef7af83f0 (rust-diskus-0.9.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2025-b25b36281f (rust-diskus-0.9.0-1.el10_2) has been pushed to the Fedora EPEL 10.2 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2025-6ad12a8dfc (rust-diskus-0.9.0-1.el10_1) has been pushed to the Fedora EPEL 10.1 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2025-37b0f6eb51 (rust-diskus-0.9.0-1.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. |