Bug 2422923 - Review Request: rust-diskus - Minimal, fast alternative to 'du -sh'
Summary: Review Request: rust-diskus - Minimal, fast alternative to 'du -sh'
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/diskus
Whiteboard:
Depends On:
Blocks: 2422900
TreeView+ depends on / blocked
 
Reported: 2025-12-16 20:47 UTC by Ben Beasley
Modified: 2025-12-26 01:28 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-12-16 23:23:24 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
Configuration file for rust2rpm (894 bytes, text/plain)
2025-12-16 20:47 UTC, Ben Beasley
no flags Details
Updated configuration file for rust2rpm (895 bytes, text/plain)
2025-12-16 20:53 UTC, Ben Beasley
no flags Details

Description Ben Beasley 2025-12-16 20:47:52 UTC
Created attachment 2118970 [details]
Configuration file for rust2rpm

Spec URL: https://music.fedorapeople.org/rust-diskus.spec
SRPM URL: https://music.fedorapeople.org/rust-diskus-0.9.0-1.fc43.src.rpm
Description: A minimal, fast alternative to 'du -sh'.
Fedora Account System Username: music

This is a nice little command-line tool that also provides a library interface required by uv 0.9.18 and later.

Comment 1 Ben Beasley 2025-12-16 20:53:10 UTC
Created attachment 2118971 [details]
Updated configuration file for rust2rpm

Corrected a minor error in a patch comment and re-uploaded the spec and SRPM.

Comment 2 Fedora Review Service 2025-12-16 20:54:59 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9915946
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2422923-rust-diskus/fedora-rawhide-x86_64/09915946-rust-diskus/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2025-12-16 20:55:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9915947
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2422923-rust-diskus/fedora-rawhide-x86_64/09915947-rust-diskus/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2025-12-16 22:12:07 UTC
Package looks good to me, only one minor thing:

The project appears to ship its own man page (doc/diskus.1) - why are you building one with help2man instead?

Comment 5 Ben Beasley 2025-12-16 22:32:38 UTC
(In reply to Fabio Valentini from comment #4)
> Package looks good to me, only one minor thing:
> 
> The project appears to ship its own man page (doc/diskus.1) - why are you
> building one with help2man instead?

Only because I forgot to look closely enough at the source tree. Thank you for catching that. Let me fix it.

Comment 6 Fabio Valentini 2025-12-16 22:38:56 UTC
Great. I trust that you'll fix that - and since it was the only issue I can see ...

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ patches are documented and reasonable
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ licenses of statically linked dependencies are correctly taken into account
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 7 Ben Beasley 2025-12-16 22:46:45 UTC
Thank you!

https://release-monitoring.org/project/94900/

Comment 8 Fedora Admin user for bugzilla script actions 2025-12-16 22:47:37 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-diskus

Comment 9 Fedora Update System 2025-12-16 23:18:49 UTC
FEDORA-2025-726ece9813 (rust-diskus-0.9.0-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-726ece9813

Comment 10 Fedora Update System 2025-12-16 23:23:24 UTC
FEDORA-2025-726ece9813 (rust-diskus-0.9.0-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2025-12-17 06:39:52 UTC
FEDORA-2025-1396f1dd8e (rust-diskus-0.9.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-1396f1dd8e

Comment 12 Fedora Update System 2025-12-17 06:58:12 UTC
FEDORA-2025-7ef7af83f0 (rust-diskus-0.9.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-7ef7af83f0

Comment 13 Fedora Update System 2025-12-17 07:44:58 UTC
FEDORA-EPEL-2025-b25b36281f (rust-diskus-0.9.0-1.el10_2) has been submitted as an update to Fedora EPEL 10.2.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-b25b36281f

Comment 14 Fedora Update System 2025-12-17 07:55:02 UTC
FEDORA-EPEL-2025-6ad12a8dfc (rust-diskus-0.9.0-1.el10_1) has been submitted as an update to Fedora EPEL 10.1.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-6ad12a8dfc

Comment 15 Fedora Update System 2025-12-17 10:11:46 UTC
FEDORA-EPEL-2025-37b0f6eb51 (rust-diskus-0.9.0-1.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-37b0f6eb51

Comment 16 Fedora Update System 2025-12-18 01:31:15 UTC
FEDORA-EPEL-2025-b25b36281f has been pushed to the Fedora EPEL 10.2 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-b25b36281f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2025-12-18 01:32:38 UTC
FEDORA-2025-1396f1dd8e has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-1396f1dd8e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-1396f1dd8e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2025-12-18 01:36:59 UTC
FEDORA-EPEL-2025-6ad12a8dfc has been pushed to the Fedora EPEL 10.1 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-6ad12a8dfc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Fedora Update System 2025-12-18 01:44:23 UTC
FEDORA-EPEL-2025-37b0f6eb51 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-37b0f6eb51

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 20 Fedora Update System 2025-12-18 01:55:56 UTC
FEDORA-2025-7ef7af83f0 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-7ef7af83f0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-7ef7af83f0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 21 Fedora Update System 2025-12-26 00:44:04 UTC
FEDORA-2025-1396f1dd8e (rust-diskus-0.9.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 22 Fedora Update System 2025-12-26 00:57:06 UTC
FEDORA-2025-7ef7af83f0 (rust-diskus-0.9.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 23 Fedora Update System 2025-12-26 01:15:52 UTC
FEDORA-EPEL-2025-b25b36281f (rust-diskus-0.9.0-1.el10_2) has been pushed to the Fedora EPEL 10.2 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 24 Fedora Update System 2025-12-26 01:25:43 UTC
FEDORA-EPEL-2025-6ad12a8dfc (rust-diskus-0.9.0-1.el10_1) has been pushed to the Fedora EPEL 10.1 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 25 Fedora Update System 2025-12-26 01:28:28 UTC
FEDORA-EPEL-2025-37b0f6eb51 (rust-diskus-0.9.0-1.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.