Bug 2425545
| Summary: | Review Request: perl-Sys-CpuAffinity - Sys::CpuAffinity - Set CPU affinity for processes | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Philippe Coval <rzr> | ||||||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | rawhide | CC: | laudin.molina, package-review | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| URL: | http://search.cpan.org/dist/Sys-CpuAffinity/ | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | --- | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | Type: | --- | |||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Philippe Coval
2025-12-26 18:48:08 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9952874 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2425545-perl-sys-cpuaffinity/fedora-rawhide-x86_64/09952874-perl-Sys-CpuAffinity/fedora-review/review.txt Found issues: - Explicit dependency on perl-devel is not allowed unless building architecture-specific code which links to libperl.so Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Created attachment 2145716 [details]
Spec including the patch0
Created attachment 2145717 [details]
SRPM including the patch
Created attachment 2145718 [details]
Patch to upstream
Hi, The build is failing in Fedora 44. The error: ``` Error: cannot parse function definition from ' xs_getaffinity_processor_bind(pid,mask)' in solaris_processor_bind.xs, line 134 Code is not inside a function (maybe last function was ended by a blank line followed by a statement on column one?) in solaris_processor_bind.xs, line 134 ``` The build fails because `contrib/solaris_processor_bind.xs` line 134 has two unexpected spaces, making xsubpp 3.61 from Fedora 44 complains. Spec + patch + new SRPM attached. Tested in fedora-44-x86_64 environment. Note that upstream fixed this in 1.13. I'll be happy to package the updated upstream version. This is my first contribution attempt and I welcome mentoring as well. Laudin Hi Phil, I created a PR to your for with a minimal fix to enable building version 1.12 in Fedora 44. https://github.com/rzr/Sys-CpuAffinity/pull/2 Thanks, Laudin Hi, Note this I created a review request for pristine-tar (https://bugzilla.redhat.com/show_bug.cgi?id=2498325), that depends on Sys-CpuAffinity. Laudin |