Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://copr-dist-git.fedorainfracloud.org/packages/rzrfreefr/fedora/perl-Sys-CpuAffinity.git/tree/perl-Sys-CpuAffinity.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/rzrfreefr/fedora/srpm-builds/09952672/perl-Sys-CpuAffinity-1.12-1.src.rpm Description: Sys::CpuAffinity - Set CPU affinity for processes Fedora Account System Username: rzrfreefr Hi, This is my 1st contribution attempt to Fedora, mentoring is welcome. The motivation for this work is to enable packaging of the following tools: - pristine-tar : https://joeyh.name/code/pristine-tar/ - git-buildpackage : https://github.com/agx/git-buildpackage For the context, previous links were generated from copr: https://copr.fedorainfracloud.org/coprs/rzrfreefr/fedora/build/9952672/ It pulled my working repo in: https://github.com/rzr/Sys-CpuAffinity/commits/pcoval/rpm/tito/master/ Which is based on an outdated git-mirror of CPAN for upstream repo https://github.com/gitpan/Sys-CpuAffinity There I imported the upstream archive from (like in .spec file) https://cpan.metacpan.org/authors/id/M/MO/MOB/Sys-CpuAffinity-1.12.tar.gz And forwarded it to the repo i have been forked for my tito packaging: https://github.com/gitpan/Sys-CpuAffinity/pull/1 Regards
Copr build: https://copr.fedorainfracloud.org/coprs/build/9952874 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2425545-perl-sys-cpuaffinity/fedora-rawhide-x86_64/09952874-perl-Sys-CpuAffinity/fedora-review/review.txt Found issues: - Explicit dependency on perl-devel is not allowed unless building architecture-specific code which links to libperl.so Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2145716 [details] Spec including the patch0
Created attachment 2145717 [details] SRPM including the patch
Created attachment 2145718 [details] Patch to upstream
Hi, The build is failing in Fedora 44. The error: ``` Error: cannot parse function definition from ' xs_getaffinity_processor_bind(pid,mask)' in solaris_processor_bind.xs, line 134 Code is not inside a function (maybe last function was ended by a blank line followed by a statement on column one?) in solaris_processor_bind.xs, line 134 ``` The build fails because `contrib/solaris_processor_bind.xs` line 134 has two unexpected spaces, making xsubpp 3.61 from Fedora 44 complains. Spec + patch + new SRPM attached. Tested in fedora-44-x86_64 environment. Note that upstream fixed this in 1.13. I'll be happy to package the updated upstream version. This is my first contribution attempt and I welcome mentoring as well. Laudin
Hi Phil, I created a PR to your for with a minimal fix to enable building version 1.12 in Fedora 44. https://github.com/rzr/Sys-CpuAffinity/pull/2 Thanks, Laudin
Hi, Note this I created a review request for pristine-tar (https://bugzilla.redhat.com/show_bug.cgi?id=2498325), that depends on Sys-CpuAffinity. Laudin