Bug 2427954
| Summary: | Review Request: texlive-collection-fontsextra - Additional fonts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <spotrh> |
| Component: | Package Review | Assignee: | Miroslav Suchý <msuchy> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | msuchy, package-review |
| Target Milestone: | --- | Flags: | msuchy:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://tug.org/texlive/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-02-07 13:55:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Tom "spot" Callaway
2026-01-08 15:34:59 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9987230 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2427954-texlive-collection-fontsextra/fedora-rawhide-x86_64/09987230-texlive-collection-fontsextra/fedora-review/review.txt Found issues: - License file COPYING is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/texlive-collection-fontsextra/diff.txt Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Updated to the latest version of the collection, adds a few new components, fixes descriptions and licensing. New Spec URL: https://spot.fedorapeople.org/tl2025/texlive-collection-fontsextra.spec New SRPM URL: https://spot.fedorapeople.org/tl2025/texlive-collection-fontsextra-svn77044-1.fc44.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/10001848 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2427954-texlive-collection-fontsextra/srpm-builds/10001848/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. OMG, this one is huge. Are you sure you do not want to split it even more?
> LicenseRef-gfl
> LicenseRef-Collection
Not a valid license string. Note they occur several times in the spec file.
Otherwise LGTM.
(In reply to Miroslav Suchý from comment #4) > OMG, this one is huge. Are you sure you do not want to split it even more? > > > LicenseRef-gfl > > LicenseRef-Collection No, because then I'm inventing arbitrary splits that don't reflect upstream. > Not a valid license string. Note they occur several times in the spec file. I love upstream TeXLive and their approach to licensing. LOVE. The GUST Font License is just the LPPL. Upstream sometimes calls it "gfl" or "gfsl". My tooling now properly catches and handles both cases. New SPEC: https://spot.fedorapeople.org/tl2025/texlive-collection-fontsextra.spec New SRPM: https://spot.fedorapeople.org/tl2025/texlive-collection-fontsextra-svn77044-2.fc44.src.rpm Fixes incorrect license strings and adds the AppData validation: Copr build: https://copr.fedorainfracloud.org/coprs/build/10039188 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2427954-texlive-collection-fontsextra/fedora-rawhide-x86_64/10039188-texlive-collection-fontsextra/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. APPROVED The Pagure repository was created at https://src.fedoraproject.org/rpms/texlive-collection-fontsextra |