Bug 2427954 - Review Request: texlive-collection-fontsextra - Additional fonts
Summary: Review Request: texlive-collection-fontsextra - Additional fonts
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact: Fedora Extras Quality Assurance
URL: http://tug.org/texlive/
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-01-08 15:34 UTC by Tom "spot" Callaway
Modified: 2026-02-07 13:55 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-02-07 13:55:30 UTC
Type: ---
Embargoed:
msuchy: fedora-review+


Attachments (Terms of Use)

Description Tom "spot" Callaway 2026-01-08 15:34:59 UTC
Spec URL: https://spot.fedorapeople.org/tl2025/texlive-collection-fontsextra.spec
SRPM URL: https://spot.fedorapeople.org/tl2025/texlive-collection-fontsextra-svn75960-2.fc44.src.rpm
Description: Additional fonts
Fedora Account System Username: spot

This package is a split out version of what used to be all mashed together in the "texlive" package. It is split out by "collection", which is an upstream TeXLive concept.
These packages are difficult to test in isolation, but they are all available in this copr: https://copr.fedorainfracloud.org/coprs/spot/texlive-2025
All of the components within this package are noarch, they do not need to be built, and they very rarely need to be patched. Accordingly, this package does not unpack all of the component files during %prep (this is the same behavior as current "texlive"), because it would require a large amount of files to be unnecessarily written to disk twice, slowing down the package build process by 2x. The package you're looking at might seem small, but some of these collections are pretty big. I would strongly prefer to have this package continue to work in that way, but if you feel strongly, you can plead your case here. :)

Comment 1 Fedora Review Service 2026-01-08 17:49:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9987230
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2427954-texlive-collection-fontsextra/fedora-rawhide-x86_64/09987230-texlive-collection-fontsextra/fedora-review/review.txt

Found issues:

- License file COPYING is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text
- Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/texlive-collection-fontsextra/diff.txt
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Tom "spot" Callaway 2026-01-12 19:13:08 UTC
Updated to the latest version of the collection, adds a few new components, fixes descriptions and licensing.

New Spec URL: https://spot.fedorapeople.org/tl2025/texlive-collection-fontsextra.spec
New SRPM URL: https://spot.fedorapeople.org/tl2025/texlive-collection-fontsextra-svn77044-1.fc44.src.rpm

Comment 3 Fedora Review Service 2026-01-12 19:15:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10001848
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2427954-texlive-collection-fontsextra/srpm-builds/10001848/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Miroslav Suchý 2026-01-18 13:01:53 UTC
OMG, this one is huge. Are you sure you do not want to split it even more?

> LicenseRef-gfl
> LicenseRef-Collection
 
Not a valid license string. Note they occur several times in the spec file.

Otherwise LGTM.

Comment 5 Tom "spot" Callaway 2026-01-20 16:53:33 UTC
(In reply to Miroslav Suchý from comment #4)
> OMG, this one is huge. Are you sure you do not want to split it even more?
> 
> > LicenseRef-gfl
> > LicenseRef-Collection

No, because then I'm inventing arbitrary splits that don't reflect upstream.

> Not a valid license string. Note they occur several times in the spec file.

I love upstream TeXLive and their approach to licensing. LOVE.

The GUST Font License is just the LPPL. Upstream sometimes calls it "gfl" or "gfsl". My tooling now properly catches and handles both cases.

New SPEC: https://spot.fedorapeople.org/tl2025/texlive-collection-fontsextra.spec
New SRPM: https://spot.fedorapeople.org/tl2025/texlive-collection-fontsextra-svn77044-2.fc44.src.rpm

Fixes incorrect license strings and adds the AppData validation:

Comment 6 Fedora Review Service 2026-01-20 17:51:35 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10039188
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2427954-texlive-collection-fontsextra/fedora-rawhide-x86_64/10039188-texlive-collection-fontsextra/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Miroslav Suchý 2026-01-20 18:28:42 UTC
APPROVED

Comment 8 Fedora Admin user for bugzilla script actions 2026-01-24 00:38:43 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/texlive-collection-fontsextra


Note You need to log in before you can comment on or make changes to this bug.