Bug 2427963
| Summary: | Review Request: texlive-collection-langchinese - Chinese | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <spotrh> |
| Component: | Package Review | Assignee: | Miroslav Suchý <msuchy> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | msuchy, package-review |
| Target Milestone: | --- | Flags: | msuchy:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://tug.org/texlive/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-02-07 13:55:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Tom "spot" Callaway
2026-01-08 15:44:55 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9987249 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2427963-texlive-collection-langchinese/fedora-rawhide-x86_64/09987249-texlive-collection-langchinese/fedora-review/review.txt Found issues: - License file COPYING is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/texlive-collection-langchinese/diff.txt Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. New Spec URL: https://spot.fedorapeople.org/tl2025/texlive-collection-langchinese.spec New SRPM URL: https://spot.fedorapeople.org/tl2025/texlive-collection-langchinese-svn76973-1.fc44.src.rpm Update to svn76973, fix descriptions, updated components [fedora-review-service-build] You install appstream data, but you do not validate it. See https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ > patch -p0 < %{_sourcedir}/texlive-xtuthesis-use-diagbox.patch
IMHO you should use %patch macro.
(In reply to Miroslav Suchý from comment #5) > > patch -p0 < %{_sourcedir}/texlive-xtuthesis-use-diagbox.patch > > IMHO you should use %patch macro. I'm not sure its possible to use the %patch macro here, without changing the spec to unpack all the sources in %prep, which, as previously stated, I don't really want to do. >RPM build warnings:
> absolute symlink: /usr/share/fonts/fandol -> /usr/share/texlive/texmf-dist/fonts/opentype/public/fandol
Should this be a relative symlink?
(In reply to Miroslav Suchý from comment #7) > >RPM build warnings: > > absolute symlink: /usr/share/fonts/fandol -> /usr/share/texlive/texmf-dist/fonts/opentype/public/fandol > > Should this be a relative symlink? It hasn't been for years. If you think it needs to be, I can adjust it. New Spec URL: https://spot.fedorapeople.org/tl2025/texlive-collection-langchinese.spec New SRPM URL: https://spot.fedorapeople.org/tl2025/texlive-collection-langchinese-svn76973-2.fc44.src.rpm Fix Knuth license tag, validate appdata. OK. I think I can live with that patch and symlink issue. APPROVED The Pagure repository was created at https://src.fedoraproject.org/rpms/texlive-collection-langchinese |