Spec URL: https://spot.fedorapeople.org/tl2025/texlive-collection-langchinese.spec SRPM URL: https://spot.fedorapeople.org/tl2025/texlive-collection-langchinese-svn72136-2.fc44.src.rpm Description: Chinese Support for Chinese; additional packages in collection-langcjk. Fedora Account System Username: spot This package is a split out version of what used to be all mashed together in the "texlive" package. It is split out by "collection", which is an upstream TeXLive concept. These packages are difficult to test in isolation, but they are all available in this copr: https://copr.fedorainfracloud.org/coprs/spot/texlive-2025 All of the components within this package are noarch, they do not need to be built, and they very rarely need to be patched. Accordingly, this package does not unpack all of the component files during %prep (this is the same behavior as current "texlive"), because it would require a large amount of files to be unnecessarily written to disk twice, slowing down the package build process by 2x. The package you're looking at might seem small, but some of these collections are pretty big. I would strongly prefer to have this package continue to work in that way, but if you feel strongly, you can plead your case here. :)
Copr build: https://copr.fedorainfracloud.org/coprs/build/9987249 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2427963-texlive-collection-langchinese/fedora-rawhide-x86_64/09987249-texlive-collection-langchinese/fedora-review/review.txt Found issues: - License file COPYING is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/texlive-collection-langchinese/diff.txt Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
New Spec URL: https://spot.fedorapeople.org/tl2025/texlive-collection-langchinese.spec New SRPM URL: https://spot.fedorapeople.org/tl2025/texlive-collection-langchinese-svn76973-1.fc44.src.rpm Update to svn76973, fix descriptions, updated components
[fedora-review-service-build]
You install appstream data, but you do not validate it. See https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/
> patch -p0 < %{_sourcedir}/texlive-xtuthesis-use-diagbox.patch IMHO you should use %patch macro.
(In reply to Miroslav Suchý from comment #5) > > patch -p0 < %{_sourcedir}/texlive-xtuthesis-use-diagbox.patch > > IMHO you should use %patch macro. I'm not sure its possible to use the %patch macro here, without changing the spec to unpack all the sources in %prep, which, as previously stated, I don't really want to do.
>RPM build warnings: > absolute symlink: /usr/share/fonts/fandol -> /usr/share/texlive/texmf-dist/fonts/opentype/public/fandol Should this be a relative symlink?
(In reply to Miroslav Suchý from comment #7) > >RPM build warnings: > > absolute symlink: /usr/share/fonts/fandol -> /usr/share/texlive/texmf-dist/fonts/opentype/public/fandol > > Should this be a relative symlink? It hasn't been for years. If you think it needs to be, I can adjust it.
New Spec URL: https://spot.fedorapeople.org/tl2025/texlive-collection-langchinese.spec New SRPM URL: https://spot.fedorapeople.org/tl2025/texlive-collection-langchinese-svn76973-2.fc44.src.rpm Fix Knuth license tag, validate appdata.
OK. I think I can live with that patch and symlink issue. APPROVED
The Pagure repository was created at https://src.fedoraproject.org/rpms/texlive-collection-langchinese