Bug 2428626
| Summary: | Review Request: gnome-shell-extension-logo-menu - Quick access menu for the GNOME panel | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Carl George 🎩 <carl> | ||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | ngompa13, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | ngompa13:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/Aryan20/Logomenu | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2026-03-16 22:36:47 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Carl George 🎩
2026-01-12 06:05:15 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9999486 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2428626-gnome-shell-extension-logo-menu/fedora-rawhide-x86_64/09999486-gnome-shell-extension-logo-menu/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review. I think I accidentally deleted that copr build while doing some cleanup. Here's links from a new build. Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/10128741-gnome-shell-extension-logo-menu/gnome-shell-extension-logo-menu.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/10128741-gnome-shell-extension-logo-menu/gnome-shell-extension-logo-menu-24.2-1.fc45.src.rpm Initial spec review: > Requires: gnome-shell >= 46 This should be using the new dependency generator stuff now by adding "BuildRequires: gnome-shell-rpm-generators", but I just tried it with https://src.fedoraproject.org/rpms/gnome-shell-extension-background-logo/pull-request/4 and it's not working. At least for now, this should manually synthesize the Provides and Requires in the form the depgen does: https://src.fedoraproject.org/rpms/gnome-shell-rpm-generators/blob/rawhide/f/gnome_shell.attr > %{_datadir}/gnome-shell/extensions/%{uuid} This should have a trailing slash so that it's always obvious this is a folder. > This should be using the new dependency generator stuff I intentionally only want to set a lower bound. This allows for users to easily test the extension with a newer GNOME version by setting the dconf key /org/gnome/shell/disable-extension-version-validation to true. And if they don't set that, they can still disable the extension without uninstalling it and proceed with system upgrades. When a future update adds compatibility they can observe in the Extensions app that the warning icon goes away and they can enable it again. Beyond just using the extension, this capability is highly beneficial for collaboration with upstream. It makes it easy to report to upstream that the extension works on new versions of GNOME (so they just need to update metadata.json), or that it doesn't work with the corresponding error message. Both of those aspects, combined with the quick six month cadence of new GNOME versions, makes the generator untenable to me. Since it's not required by the guidelines, I'll pass on this. > This should have a trailing slash This is also not required by the guidelines, and is just a personal preference, so I'll pass on this one too. Are there any review-blocking items? New build for the latest upstream version. Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/10179895-gnome-shell-extension-logo-menu/gnome-shell-extension-logo-menu.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/10179895-gnome-shell-extension-logo-menu/gnome-shell-extension-logo-menu-24.4-1.fc45.src.rpm Created attachment 2131429 [details]
The .spec file difference from Copr build 9999486 to 10179938
Copr build: https://copr.fedorainfracloud.org/coprs/build/10179938 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2428626-gnome-shell-extension-logo-menu/fedora-rawhide-x86_64/10179938-gnome-shell-extension-logo-menu/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Meh, sure. I think you should do something to acknowledge it needs to be a directory, but a strict reading doesn't indicate one way or another. Everything else about this is gravy now... * Licensing is correct * Package builds and installs * No serious rpmlint issues PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-logo-menu FEDORA-2026-263f0efcd2 (gnome-shell-extension-logo-menu-24.4-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-263f0efcd2 FEDORA-2026-263f0efcd2 (gnome-shell-extension-logo-menu-24.4-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report. |