Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/09993377-gnome-shell-extension-logo-menu/gnome-shell-extension-logo-menu.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/09993377-gnome-shell-extension-logo-menu/gnome-shell-extension-logo-menu-24.2-1.fc44.src.rpm Description: This extension gives a simple menu along with the ability to get the icon of your distro on top left part of the panel for a great look. The Icon can be customised through settings, it has both Linux and BSD logos. Fedora Account System Username: carlwgeorge
Copr build: https://copr.fedorainfracloud.org/coprs/build/9999486 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2428626-gnome-shell-extension-logo-menu/fedora-rawhide-x86_64/09999486-gnome-shell-extension-logo-menu/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review.
I think I accidentally deleted that copr build while doing some cleanup. Here's links from a new build. Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/10128741-gnome-shell-extension-logo-menu/gnome-shell-extension-logo-menu.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/10128741-gnome-shell-extension-logo-menu/gnome-shell-extension-logo-menu-24.2-1.fc45.src.rpm
Initial spec review: > Requires: gnome-shell >= 46 This should be using the new dependency generator stuff now by adding "BuildRequires: gnome-shell-rpm-generators", but I just tried it with https://src.fedoraproject.org/rpms/gnome-shell-extension-background-logo/pull-request/4 and it's not working. At least for now, this should manually synthesize the Provides and Requires in the form the depgen does: https://src.fedoraproject.org/rpms/gnome-shell-rpm-generators/blob/rawhide/f/gnome_shell.attr > %{_datadir}/gnome-shell/extensions/%{uuid} This should have a trailing slash so that it's always obvious this is a folder.